CiviCRM Community Forums (archive)

*

News:

Have a question about CiviCRM?
Get it answered quickly at the new
CiviCRM Stack Exchange Q+A site

This forum was archived on 25 November 2017. Learn more.
How to get involved.
What to do if you think you've found a bug.



  • CiviCRM Community Forums (archive) »
  • Old sections (read-only, deprecated) »
  • Support »
  • Using CiviCRM »
  • Post-installation Setup and Configuration (Moderator: Dave Greenberg) »
  • Error Message Consistency
Pages: [1]

Author Topic: Error Message Consistency  (Read 398 times)

denverdataman

  • I post occasionally
  • **
  • Posts: 93
  • Karma: 2
    • Denver DataMan Website
  • CiviCRM version: Several
  • CMS version: Drupal 6/7
Error Message Consistency
April 07, 2013, 12:39:02 pm
I am working on a site that has very basic computer users working with and they pointed out to me that the error "Please enter a valid amount" when you include a $ sign in a donation amount field is not a good error message. I went to look for this error message and I see it is in several places and sometimes has "(numbers and decimal point only" as well which is much better. Before I start changing each of these error messages in the code I want to see what the best practice is and how to go about this.

I would be glad to author a patch that solves this but there should be one error used for all these fields so it is consistent. 

I would also need some guidance on how to author the patch. 

I have attached the grep results for the error messages.

Thanks,
Steve
« Last Edit: April 07, 2013, 12:45:48 pm by denverdataman »
Steve Kessler
Owner and Lead Consultant of Denver DataMan

Michael McAndrew

  • Forum Godess / God
  • I live on this forum
  • *****
  • Posts: 1274
  • Karma: 55
    • Third Sector Design
  • CiviCRM version: various
  • CMS version: Nearly always Drupal
  • MySQL version: 5.5
  • PHP version: 5.3
Re: Error Message Consistency
April 08, 2013, 01:59:14 pm
thanks for taking the next step.

to submit a patch, first write an issue that describes the problem and your proposed solution. then create a pull request http://wiki.civicrm.org/confluence/display/CRMDOC43/GitHub+for+CiviCRM#GitHubforCiviCRM-How-To:Createyourfirstchange%28%22pull-request%22%29.

best would be for you to start along that path and let us know if you need any more help / have specific questions.
Service providers: Grow your business, build your reputation and support CiviCRM. Become a partner today

Pages: [1]
  • CiviCRM Community Forums (archive) »
  • Old sections (read-only, deprecated) »
  • Support »
  • Using CiviCRM »
  • Post-installation Setup and Configuration (Moderator: Dave Greenberg) »
  • Error Message Consistency

This forum was archived on 2017-11-26.