CiviCRM Community Forums (archive)

If this is the wrong place to post this jumble of thoughts... I apologize in advance and blame the "gosh darnit I'm going to plow through until I solve this even though it's 5 hours past my bedtime" and beg humble forgiveness...

This is utilizing the CiviDiscount 2.1 on CiviCRM 4.2.6 on Joomla 2.5.6.

1. Is it by intention that CiviDiscount extension allows you to apply discounts only to events that are Active AND Current/Future AND Public? The New/Edit Discount screen only says Active and Current/Future BUT the extension seems to rely on CRM_Event_BAO_Event::getCompleteInfo() which has a hard coded "is_public=1" in the query to fetch the list of Events?

1b. "By intention" meaning "We designed it that way on purpose" as opposed to "We used the getCompleteInfo function because it was easy and everyone that tested it makes all their events public"

2. With regards to stacking discounts... (which doesn't seem to work out of the box)... In the org.civicrm.module.cividiscount/cividiscount.php file I added the following line at/near line 386:

   while(count($discounts)) {

This is right before the line that reads:

   $discount = array_shift($discounts);

Then I added a matching } right before the line that reads:

   $form-set('_discountInfo', array(

2b. It seems to work on the front end but I'm wondering if this will do evil things that I have missed? ...I'm concerned because I'm too tired to figure out what the $form->set is trying to do and I can see it would only get the last discount.

2c. If that is harmless where/to whom do I submit a patch?

Thanks in advance!

Matt

Thanks!