CiviCRM Community Forums (archive)

*

News:

Have a question about CiviCRM?
Get it answered quickly at the new
CiviCRM Stack Exchange Q+A site
This forum was archived on 25 November 2017. Learn more.
How to get involved.
What to do if you think you've found a bug.



  • CiviCRM Community Forums (archive) »
  • Old sections (read-only, deprecated) »
  • Support »
  • Using CiviCRM »
  • Using CiviSMS »
  • Proposal to integrate official Twilio PHP library with org.civicrm.sms.twilio
Pages: [1]

Author Topic: Proposal to integrate official Twilio PHP library with org.civicrm.sms.twilio  (Read 1925 times)

mmikitka

  • I’m new here
  • *
  • Posts: 23
  • Karma: 0
Proposal to integrate official Twilio PHP library with org.civicrm.sms.twilio
April 19, 2013, 07:56:41 pm
Could somebody please clarify the reason for developing a home-grown set of PHP functions to interact with the Twilio API instead of using the official Twilio PHP library described at https://www.twilio.com/docs/php/install, with the source code hosted on GitHub at https://github.com/twilio/twilio-php?

I assume that the reason is due to licensing i.e., the official Twilio API, although released under the MIT license, does not contain the "Licensed to CiviCRM under the Academic Free License version 3.0" clause as per the CiviCRM license terms and agreements located at http://civicrm.org/what/licensing.

What is the Community's opinion on providing a secondary option of using the official Twilio PHP library with the requirement that the site administrator must independently download the Twilio PHP library source into a sub-directory of the org.civicrm.sms.twilio extension folder?

The org.civicrm.sms.twilio extension will default to the CiviCRM version (i.e. the current implementation) and provide the option for the site admin to opt-out (e.g. via a config file) and use the official Twilio PHP library.

I am referring to the org.civicrm.sms.twilio extension located at https://github.com/civicrm/civicrm-core/tree/master/tools/extensions/org.civicrm.sms.twilio

Any questions or concerns?

Donald Lobo

  • Administrator
  • I’m (like) Lobo ;)
  • *****
  • Posts: 15963
  • Karma: 470
    • CiviCRM site
  • CiviCRM version: 4.2+
  • CMS version: Drupal 7, Joomla 2.5+
  • MySQL version: 5.5.x
  • PHP version: 5.4.x
Re: Proposal to integrate official Twilio PHP library with org.civicrm.sms.twilio
April 19, 2013, 08:15:03 pm

Note that the  twilio extension was a contribution from community members (the forums posts have some history about this)

We can incorporate MIT code in the CiviCRM code base (all the packages code comes under different licenses)

I afree that we should use the official twilio library, so i would strongly recommend you post patches against the current code base

Seems like we should extract the twilio and clickatell extensions into their own github repos

lobo
A new CiviCRM Q&A resource needs YOUR help to get started. Visit our StackExchange proposed site, sign up and vote on 5 questions

mmikitka

  • I’m new here
  • *
  • Posts: 23
  • Karma: 0
Re: Proposal to integrate official Twilio PHP library with org.civicrm.sms.twilio
April 22, 2013, 06:03:36 am
Thanks lobo.  I just want to confirm a few things.

1) The twilio-php code, licensed under MIT, can be stored in the https://github.com/civicrm/civicrm-core/tree/master/tools/extensions/org.civicrm.sms.twilio repository.

2) The twilio-php code will be used by default. I'll leave the current code in place as a fallback.

3) I will post patches against the following GitHub repo on the latest 4.3 branch

4) I do not understand this statement "Seems like we should extract the twilio and clickatell extensions into their own github repos". Both the Twilio and Clickatell extensions are stored in the civicrm/civicrm-core GitHub repo: https://github.com/civicrm/civicrm-core/tree/master/tools/extensions/org.civicrm.sms.twilio

matt

Donald Lobo

  • Administrator
  • I’m (like) Lobo ;)
  • *****
  • Posts: 15963
  • Karma: 470
    • CiviCRM site
  • CiviCRM version: 4.2+
  • CMS version: Drupal 7, Joomla 2.5+
  • MySQL version: 5.5.x
  • PHP version: 5.4.x
Re: Proposal to integrate official Twilio PHP library with org.civicrm.sms.twilio
April 22, 2013, 06:52:54 am

1. Yes. I will chat with deepak and maybe for the version with your changes we will move the code to:

https://github.com/civicrm/civicrm-sms-twilio

2. Not sure why we need two copies of the code if we are relying on the twilio library

3. If we move the code, the extension can get upgraded for the 4.3 release, while we keep the current one as stable

4. See above :)

lobo
A new CiviCRM Q&A resource needs YOUR help to get started. Visit our StackExchange proposed site, sign up and vote on 5 questions

mmikitka

  • I’m new here
  • *
  • Posts: 23
  • Karma: 0
Re: Proposal to integrate official Twilio PHP library with org.civicrm.sms.twilio
April 22, 2013, 09:26:37 am
Thanks Lobo.  I created the following enhancement ticket to track this: http://issues.civicrm.org/jira/browse/CRM-12399
Pages: [1]
  • CiviCRM Community Forums (archive) »
  • Old sections (read-only, deprecated) »
  • Support »
  • Using CiviCRM »
  • Using CiviSMS »
  • Proposal to integrate official Twilio PHP library with org.civicrm.sms.twilio

This forum was archived on 2017-11-26.