CiviCRM Community Forums (archive)

*

News:

Have a question about CiviCRM?
Get it answered quickly at the new
CiviCRM Stack Exchange Q+A site

This forum was archived on 25 November 2017. Learn more.
How to get involved.
What to do if you think you've found a bug.



  • CiviCRM Community Forums (archive) »
  • Old sections (read-only, deprecated) »
  • Discussion (deprecated) »
  • Alpha and Beta Release Testing »
  • 4.3 Release Testing (Moderator: pdelbar) »
  • CRM_Mailing_BAO_Mailing:create changes
Pages: [1]

Author Topic: CRM_Mailing_BAO_Mailing:create changes  (Read 4106 times)

bpmccain

  • I post frequently
  • ***
  • Posts: 255
  • Karma: 5
  • CiviCRM version: 4.1
  • CMS version: Drupal 7.12
  • MySQL version: 5.2
  • PHP version: 5.2
CRM_Mailing_BAO_Mailing:create changes
April 24, 2013, 09:04:48 am
So there appear to have been some significant changes to CRM_Mailing_BAO_Mailing:create which I can't comprehend.

This function is called in Schedule.php (at the end of the Mailing) and now seems to overwrite all of the Mailing options that you just set in the previous 4 steps with the default options.

Is this intentional? Or a bug?

I've just had to comment out all of the new additions in a customphp folder to get things working again, which isn't a problem, but I can't understand why anyone would want to overwrite the headers, reply to email address, from e-mail address, tracking, forward reply settings etc with the default values right after they may have changed them.


Eileen

  • Forum Godess / God
  • I’m (like) Lobo ;)
  • *****
  • Posts: 4195
  • Karma: 218
    • Fuzion
Re: CRM_Mailing_BAO_Mailing:create changes
April 24, 2013, 04:27:52 pm
I believe this is where the changes stemmed from

http://issues.civicrm.org/jira/browse/CRM-11023

(NB any problems blame Chris, anything that works thank me :-)
Make today the day you step up to support CiviCRM and all the amazing organisations that are using it to improve our world - http://civicrm.org/contribute

bpmccain

  • I post frequently
  • ***
  • Posts: 255
  • Karma: 5
  • CiviCRM version: 4.1
  • CMS version: Drupal 7.12
  • MySQL version: 5.2
  • PHP version: 5.2
Re: CRM_Mailing_BAO_Mailing:create changes
April 24, 2013, 06:31:23 pm
So, from my reading, it looks like this was put in place as part of the Mailing API, and I assume that this was designed to use default headers and other settings.

However, since it is called from the last step of the CiviMail process, it seems like an unintended consequence has ben to completely overwrite all of the settings made during the CiviMail process?

Is this understanding correct?

If so, I think there needs to be some sort of if statement that treats the create function differently depending on whether it is called from the API, or elsewhere. Does that make sense?

Brian

Eileen

  • Forum Godess / God
  • I’m (like) Lobo ;)
  • *****
  • Posts: 4195
  • Karma: 218
    • Fuzion
Re: CRM_Mailing_BAO_Mailing:create changes
April 24, 2013, 06:54:45 pm
I understood that Chris tested that it was working via the UI & comments on the ticket indicate that - of course I don't know whether it was working & then broke or he didn't get it working.

If you can replicate on Demo you should log as a bug
Make today the day you step up to support CiviCRM and all the amazing organisations that are using it to improve our world - http://civicrm.org/contribute

bpmccain

  • I post frequently
  • ***
  • Posts: 255
  • Karma: 5
  • CiviCRM version: 4.1
  • CMS version: Drupal 7.12
  • MySQL version: 5.2
  • PHP version: 5.2
Re: CRM_Mailing_BAO_Mailing:create changes
April 25, 2013, 05:21:53 am
I can recreate on the demo, so it appears to be a bug. I'll log it.

Brian

Pages: [1]
  • CiviCRM Community Forums (archive) »
  • Old sections (read-only, deprecated) »
  • Discussion (deprecated) »
  • Alpha and Beta Release Testing »
  • 4.3 Release Testing (Moderator: pdelbar) »
  • CRM_Mailing_BAO_Mailing:create changes

This forum was archived on 2017-11-26.