CiviCRM Community Forums (archive)

*

News:

Have a question about CiviCRM?
Get it answered quickly at the new
CiviCRM Stack Exchange Q+A site
This forum was archived on 25 November 2017. Learn more.
How to get involved.
What to do if you think you've found a bug.



  • CiviCRM Community Forums (archive) »
  • Old sections (read-only, deprecated) »
  • Support »
  • Upgrading CiviCRM (Moderator: Deepak Srivastava) »
  • 4.3.3 merge contacts with different subtypes broken?
Pages: [1]

Author Topic: 4.3.3 merge contacts with different subtypes broken?  (Read 1138 times)

artfulrobot.com

  • I post occasionally
  • **
  • Posts: 81
  • Karma: 4
4.3.3 merge contacts with different subtypes broken?
May 13, 2013, 07:24:10 am
[grrr. just lost new post submission!]

I'm concerned that the sub types stuff in the merge facility is broken. The Merger does not ask the API for contact_sub_type, so the other code which checks isset() on that later on never acts. Adding in the missing field to the Merger suddenly throws lots of notices and does not appear to work as intended.

I can see code in form/merge that looks like it's supposed to display something extra, but I think this is broken.

I've patched 2 files attached (hopefully this time) to get rid of the errors but it's not clear to me whether this is (a) bug (b) not finished feature (c) dangerous!

Would like to know how it's supposed to work, and whether to file a bug.

Ta.

Kurund Jalmi

  • Administrator
  • I’m (like) Lobo ;)
  • *****
  • Posts: 4169
  • Karma: 128
    • CiviCRM
  • CiviCRM version: 4.x, future
  • CMS version: Drupal 7, Joomla 3.x
  • MySQL version: 5.5.x
  • PHP version: 5.4.x
Re: 4.3.3 merge contacts with different subtypes broken?
May 13, 2013, 08:37:59 am
thanks for reporting this, we will check and get back to you.

Kurund
Found this reply helpful? Support CiviCRM

Deepak Srivastava

  • Moderator
  • Ask me questions
  • *****
  • Posts: 677
  • Karma: 65
Re: 4.3.3 merge contacts with different subtypes broken?
May 14, 2013, 05:30:43 am
Ok verified. Its a missing feature. I see the merge code supporting old style of subtypes, when there were only single subtypes supported.

Plus UI doesn't populate info on subtypes as you mentioned, since the code is missing.

Please file an issue and attach your patch.
Found this reply helpful? Contribute NOW and help us improve CiviCRM with the Make it Happen! initiative.

artfulrobot.com

  • I post occasionally
  • **
  • Posts: 81
  • Karma: 4
Re: 4.3.3 merge contacts with different subtypes broken?
May 15, 2013, 03:49:56 am
Deepak, Kurund, good to be chatting with you again (been a while since I've done much with CiviCRM), hope you are well. Will file bug on Friday.

kestermuller

  • I’m new here
  • *
  • Posts: 5
  • Karma: 0
  • CiviCRM version: CiviCRM 4.4.6.
  • CMS version: Wordpress 3.4.2.
  • MySQL version: 5.5.21-
  • PHP version: 5.4
Re: 4.3.3 merge contacts with different subtypes broken?
February 10, 2015, 07:42:30 am
Afternoon.

I am wondering if these issues with merging subtypes were ever resolved?

I have just tried a few experiments and it seems that if you merge a contact with one subtype with another with a different subtype, the final record exhibits only the subtype of the contact set as the original, resulting obviously in the loss of any data stored against the omitted subtype.

I have also established that there are problems with subtypes if you import data into civi to update existing records. If you try to 'add', via the 'Fill' option, a subtype to an existing record THAT ALREADY HAS SUBTYPES, then the original subtypes are overwritten completely and data is lost.

These two inconsistencies have lost our organisation alot of data. Please help!

ayduns

  • I post occasionally
  • **
  • Posts: 64
  • Karma: 6
    • Squiffle Consulting
  • CiviCRM version: 4.5.5
  • CMS version: Drupal 7
Re: 4.3.3 merge contacts with different subtypes broken?
February 11, 2015, 07:17:22 am
There are some fixes in 4.6 for merging subtype issues - https://issues.civicrm.org/jira/browse/CRM-15681

It would be helpful if you could test your scenarios on the 4.6 sandbox site: https://civicrm.org/blogs/yashodha/announcing-civicrm-46-alpha6-release

(Re your lost data: you may be able to recover some of that by editing the contact and re-including the deleted subtypes - assuming you know what they should be.)

kestermuller

  • I’m new here
  • *
  • Posts: 5
  • Karma: 0
  • CiviCRM version: CiviCRM 4.4.6.
  • CMS version: Wordpress 3.4.2.
  • MySQL version: 5.5.21-
  • PHP version: 5.4
Re: 4.3.3 merge contacts with different subtypes broken?
February 17, 2015, 02:18:00 am
Thanks for the advice Ayduns,

I will have a look over this sandbox site and try to replicate what I was doing. I had noticed that if you reincluded the subtype the data would sometimes reappear, but there are situations where it is lost for good. I think that the import problem is a lot more serious as it may stymie new projects.

Good to know that it's being seen to tho, and thanks again.
Pages: [1]
  • CiviCRM Community Forums (archive) »
  • Old sections (read-only, deprecated) »
  • Support »
  • Upgrading CiviCRM (Moderator: Deepak Srivastava) »
  • 4.3.3 merge contacts with different subtypes broken?

This forum was archived on 2017-11-26.