Author Topic: objectRef as array or object in civicrm_post and _pre hooks (Read 708 times)

Erik Hommel · May 23, 2013, 10:55:03 am

At the moment the $objectRef in the civicrm_pre hook and the civicrm_post hook is sometimes an object and sometimes an array. I assume we do not really want this inconsistency, it is just something that crept in from the BAO's? What is the preference, object or array? Is it worth raising an issue for and putting it on the list for a sprint?

Eileen · May 23, 2013, 11:25:17 am

Erik- I thought it was an array PRE, an object POST & anything else was a bug.

I'm pretty sure we sorted out address, don't know how to deal with ones line 'entity_tag' & group_contact' - which do multiples if they do anything & any others are not on my radar. I would suggest you could log a ticket (or do a PR) against 4.4 for any individual ones you come across (& document on the wiki somewhere.

I don't know how big the problem is? My sense was that it was not too many now?

Erich Schulz · May 24, 2013, 07:33:48 pm

remember reading a long post in drupal about this... and seemed unresolved

Eileen is there a reason for that convention? (just a one word response is enough - just curious)

Donald Lobo · May 25, 2013, 08:05:46 am

historic reason:

most bao objects get arrays as their parameters for the object values. You send this array to a "pre" hook which can potentially modify what values get to the object and/or modify the create behavior of the function. hence an array is sent for the pre hook

for the post hook, the object is already created

lobo

CiviCRM Community Forums (archive)

News:

Author Topic: objectRef as array or object in civicrm_post and _pre hooks (Read 708 times)

Erik Hommel

objectRef as array or object in civicrm_post and _pre hooks

Eileen

Re: objectRef as array or object in civicrm_post and _pre hooks

Erich Schulz

Re: objectRef as array or object in civicrm_post and _pre hooks

Donald Lobo

Re: objectRef as array or object in civicrm_post and _pre hooks