CiviCRM Community Forums (archive)

*

News:

Have a question about CiviCRM?
Get it answered quickly at the new
CiviCRM Stack Exchange Q+A site
This forum was archived on 25 November 2017. Learn more.
How to get involved.
What to do if you think you've found a bug.



  • CiviCRM Community Forums (archive) »
  • Old sections (read-only, deprecated) »
  • Support »
  • Using CiviCRM »
  • Using Core CiviCRM Functions (Moderator: Yashodha Chaku) »
  • Bug in Mailing Labels
Pages: [1]

Author Topic: Bug in Mailing Labels  (Read 1497 times)

clarkac

  • Administrator
  • Ask me questions
  • *****
  • Posts: 399
  • Karma: 11
  • CiviCRM version: 4.4.11 & 4.5.5
  • CMS version: Drupal 7
  • MySQL version: 5.1.61-cll
  • PHP version: 5.3.27
Bug in Mailing Labels
September 13, 2013, 09:30:53 am
When I create mailing labels and leave the first option checked i.e 'Do not print labels for contacts with "Do Not Mail" privacy option checked'  and leave the next two options left unchecked, all is well and labels include the contacts prefix - e.g 'Mr Andrew Clark'.

But... if I check the next option (which my client did today!) - that is - 'Merge labels for contacts with the same address' then prefix is dropped and I get just 'Andrew Clark'  which is incorrect and unfortunately unacceptable for this client.  Checking or unchecking the third option makes no difference.

This bug is 100% reproducible on the demo system (try with Dr Elizabeth Barkley-Wilson) and is also in 4.4 Beta2.  OK if I raise this as an issue?
« Last Edit: September 13, 2013, 09:46:11 am by clarkac »
Andy Clark

Donald Lobo

  • Administrator
  • I’m (like) Lobo ;)
  • *****
  • Posts: 15963
  • Karma: 470
    • CiviCRM site
  • CiviCRM version: 4.2+
  • CMS version: Drupal 7, Joomla 2.5+
  • MySQL version: 5.5.x
  • PHP version: 5.4.x
Re: Bug in Mailing Labels
September 13, 2013, 10:53:17 am

Since this is unacceptable to your client, can you please take a look at the code and submit a patch to fix this bug

thanx

lobo
A new CiviCRM Q&A resource needs YOUR help to get started. Visit our StackExchange proposed site, sign up and vote on 5 questions

clarkac

  • Administrator
  • Ask me questions
  • *****
  • Posts: 399
  • Karma: 11
  • CiviCRM version: 4.4.11 & 4.5.5
  • CMS version: Drupal 7
  • MySQL version: 5.1.61-cll
  • PHP version: 5.3.27
Re: Bug in Mailing Labels
September 13, 2013, 11:17:08 am
Would that I could fix this!  My programming skills are based around PL/1...and a few other languages not used today.  Actually I was wary of using that expression about being 'unacceptable' - I guess that was a mistake - my apologies. What I mean is that in some countries how people are addressed on mailings is quite important - there are some rules that you have to abide by and this includes getting their prefix (and suffix if they have one) absolutely right.   I know that's true in the UK and at least in Germany, and it also depends on who the target audience is.  Anyway, what I mean is that this bug should be fixed because of these reasons.  I'm contributing to CiviCRM by testing 4.4, but sorry I'm not (yet) into PHP.  If there's any other way I can help, let me know... I'm booked into CiviCon London by the way (as an implementor  :) )  And I think Civi is a great system.
Andy Clark

clarkac

  • Administrator
  • Ask me questions
  • *****
  • Posts: 399
  • Karma: 11
  • CiviCRM version: 4.4.11 & 4.5.5
  • CMS version: Drupal 7
  • MySQL version: 5.1.61-cll
  • PHP version: 5.3.27
Re: Bug in Mailing Labels
September 15, 2013, 06:27:37 am
Issue http://issues.civicrm.org/jira/browse/CRM-13396 raised
Andy Clark

JonGold

  • Ask me questions
  • ****
  • Posts: 638
  • Karma: 81
    • Palante Technology
  • CiviCRM version: 4.1 to the latest
  • CMS version: Drupal 6-7, Wordpress 4.0+
  • PHP version: PHP 5.3-5.5
Re: Bug in Mailing Labels
September 15, 2013, 01:24:40 pm
I decided to procrastinate from my actual work, so I took a look at this code.  I have a patch; I'll submit a pull request shortly.

Note that this will not add a prefix when names are combined - "Mr. Jon Goldberg" and "Ms. Mary Goldberg" will combine to "Jon and Mary Goldberg", not "Mr. Jon and Mary Goldberg".  This is by design, and I think reflects the correct behavior.
Sign up to StackExchange and get free expert CiviCRM advice: https://civicrm.org/blogs/colemanw/get-exclusive-access-free-expert-help

JonGold

  • Ask me questions
  • ****
  • Posts: 638
  • Karma: 81
    • Palante Technology
  • CiviCRM version: 4.1 to the latest
  • CMS version: Drupal 6-7, Wordpress 4.0+
  • PHP version: PHP 5.3-5.5
Re: Bug in Mailing Labels
September 26, 2013, 08:53:18 am
Hi Andy,

Dave merged this patch into the 4.4 branch, and I saw that you've been testing 4.4, so you should see this change reflected in the next beta!

Jon
Sign up to StackExchange and get free expert CiviCRM advice: https://civicrm.org/blogs/colemanw/get-exclusive-access-free-expert-help

clarkac

  • Administrator
  • Ask me questions
  • *****
  • Posts: 399
  • Karma: 11
  • CiviCRM version: 4.4.11 & 4.5.5
  • CMS version: Drupal 7
  • MySQL version: 5.1.61-cll
  • PHP version: 5.3.27
Re: Bug in Mailing Labels
September 26, 2013, 08:54:21 am
Thanks, much appreciated.  I will look out for it.  Andy
Andy Clark

clarkac

  • Administrator
  • Ask me questions
  • *****
  • Posts: 399
  • Karma: 11
  • CiviCRM version: 4.4.11 & 4.5.5
  • CMS version: Drupal 7
  • MySQL version: 5.1.61-cll
  • PHP version: 5.3.27
Re: Bug in Mailing Labels
October 09, 2013, 12:54:00 am
Just tested this in 4.4 beta4 and thanks, this is fixed.    :) ;)
Andy Clark
Pages: [1]
  • CiviCRM Community Forums (archive) »
  • Old sections (read-only, deprecated) »
  • Support »
  • Using CiviCRM »
  • Using Core CiviCRM Functions (Moderator: Yashodha Chaku) »
  • Bug in Mailing Labels

This forum was archived on 2017-11-26.