CiviCRM Community Forums (archive)

*

News:

Have a question about CiviCRM?
Get it answered quickly at the new
CiviCRM Stack Exchange Q+A site

This forum was archived on 25 November 2017. Learn more.
How to get involved.
What to do if you think you've found a bug.



  • CiviCRM Community Forums (archive) »
  • Old sections (read-only, deprecated) »
  • Support »
  • Upgrading CiviCRM (Moderator: Deepak Srivastava) »
  • 4.3.5 accordion controls in advanced search not working in IE8
Pages: [1]

Author Topic: 4.3.5 accordion controls in advanced search not working in IE8  (Read 1168 times)

nickholden

  • I post occasionally
  • **
  • Posts: 111
  • Karma: 1
  • CiviCRM version: 4.4.1
  • CMS version: Drupal 7
  • MySQL version: 5.5.32
  • PHP version: 5.4
4.3.5 accordion controls in advanced search not working in IE8
September 26, 2013, 01:47:16 am
Having upgraded our test instance on Monday to 4.3.5, we've noticed that the accordion controls for form sections in the 'advanced search' function are no longer working, when accessing the site in IE8. This is unfortunate since our users are using IE8 as a corporate policy, and that isn't likely to change. Accordion controls in other functions and components of CiviCRM continue to work normally. Is this behaviour known? Is there a workaround or fix? Thanks.

Donald Lobo

  • Administrator
  • I’m (like) Lobo ;)
  • *****
  • Posts: 15963
  • Karma: 470
    • CiviCRM site
  • CiviCRM version: 4.2+
  • CMS version: Drupal 7, Joomla 2.5+
  • MySQL version: 5.5.x
  • PHP version: 5.4.x
Re: 4.3.5 accordion controls in advanced search not working in IE8
September 26, 2013, 07:18:45 am

Can you use IE8 javascript debugger and narrow down the js error

might also want to see if you get the same error on the drupal demo site which is running 4.3.6

lobo
A new CiviCRM Q&A resource needs YOUR help to get started. Visit our StackExchange proposed site, sign up and vote on 5 questions

Coleman Watts

  • Administrator
  • I’m (like) Lobo ;)
  • *****
  • Posts: 2346
  • Karma: 183
  • CiviCRM version: The Bleeding Edge
  • CMS version: Various
Re: 4.3.5 accordion controls in advanced search not working in IE8
September 26, 2013, 10:36:10 am
I just tested in IE8 and the latest version of CiviCRM 4.3 and advanced search is working fine.
Can you give more details?
Try asking your question on the new CiviCRM help site.

nickholden

  • I post occasionally
  • **
  • Posts: 111
  • Karma: 1
  • CiviCRM version: 4.4.1
  • CMS version: Drupal 7
  • MySQL version: 5.5.32
  • PHP version: 5.4
Re: 4.3.5 accordion controls in advanced search not working in IE8
September 30, 2013, 07:49:34 am
Corporate policy has disabled the Developer Tools in IE.   ???

The demo site seems to be using 4.3.4 - on the demo site, in my IE8 browser, the 'advanced search' page works as I would expect.

In my local test site, running 4.3.5, it does not. When the advanced search page loads in the browser, clicking on the accordion controls has no effect. The cursor icon changes to the pointing finger, suggesting that the control is clickable, but clicking on it just has no effect.

The IE status bar shows "Done, but with errors on page." Clicking on that gives the following error list:

Expected identifier, string or number:
rest.js
line 106
char: 5

Object doesn't support this property or method:
advanced
line 95
char: 1

Expected identifier, string or number
advanced
line 654
char 3

Hope that helps a bit.

Donald Lobo

  • Administrator
  • I’m (like) Lobo ;)
  • *****
  • Posts: 15963
  • Karma: 470
    • CiviCRM site
  • CiviCRM version: 4.2+
  • CMS version: Drupal 7, Joomla 2.5+
  • MySQL version: 5.5.x
  • PHP version: 5.4.x
Re: 4.3.5 accordion controls in advanced search not working in IE8
September 30, 2013, 09:08:30 am

the demo site runs the code via git, and hence the version number is not accurate. pretty sure we updated it last week, so its close to 4.3.6 or more

in general for IE support, we rely on folks in the community to contribute patches and potential fixes. if it does work on demo, but not locally, i would check the theme and see if switching to a different theme works

lobo
A new CiviCRM Q&A resource needs YOUR help to get started. Visit our StackExchange proposed site, sign up and vote on 5 questions

nickholden

  • I post occasionally
  • **
  • Posts: 111
  • Karma: 1
  • CiviCRM version: 4.4.1
  • CMS version: Drupal 7
  • MySQL version: 5.5.32
  • PHP version: 5.4
Re: 4.3.5 accordion controls in advanced search not working in IE8
October 01, 2013, 02:56:02 am
Hi lobo. It works on demo. But not locally - I've tried with three different themes, including Garland (drupal default). Same behaviour each time.

We've tracked it down to two stray commas - one on line 105 of js/rest.js and one on line 65 of templates/CRM/Contact/Form/Search/AdvancedCriteria.tpl

I'll have a go at submitting a patch - but presumably it only needs to be submitted against 4.3.5 since the demo site is working OK?

nickholden

  • I post occasionally
  • **
  • Posts: 111
  • Karma: 1
  • CiviCRM version: 4.4.1
  • CMS version: Drupal 7
  • MySQL version: 5.5.32
  • PHP version: 5.4
Re: 4.3.5 accordion controls in advanced search not working in IE8
October 01, 2013, 03:10:15 am
Issue - and two minor patches - submitted: CRM-13476

nickholden

  • I post occasionally
  • **
  • Posts: 111
  • Karma: 1
  • CiviCRM version: 4.4.1
  • CMS version: Drupal 7
  • MySQL version: 5.5.32
  • PHP version: 5.4
Re: 4.3.5 accordion controls in advanced search not working in IE8
October 01, 2013, 03:20:02 am
I've checked the code on the demo site - and the stray commas are still in the code. Now I'm really confused. IE8 will run the demo site even though the javascript is mildly malformed, but it won't run 4.3.5 with the same errors in it. Did the document type definitions - or something else 'meta' - get changed between versions to mean that IE will happily ignore errors in 4.3.6 that it barfed over in 4.3.5?

Anyway, I've got a working site again, so I'm happy. Confused, but happy.

Pages: [1]
  • CiviCRM Community Forums (archive) »
  • Old sections (read-only, deprecated) »
  • Support »
  • Upgrading CiviCRM (Moderator: Deepak Srivastava) »
  • 4.3.5 accordion controls in advanced search not working in IE8

This forum was archived on 2017-11-26.