CiviCRM Community Forums (archive)

When sending a CiviMail with no text part, the text part is generated from the HTML part using the html2text package.

This conversion occurs before token replacement, so html2text has to process links of the form "{action.forward}". html2text thinks these are relative links so it prefixes them giving "http://example.org/{action.forward}". The token processing then converts this to "http://example.org/http://example.org/civicrm/mailing/forward?..." which is invalid.

One option is to do the token processing BEFORE generating the text part.

Another option is to modify html2text slightly ...

--- /data/Download/CiviCRM/civicrm-4.4.beta4-drupal/./packages/html2text/rcube_html2text.php 2013-10-02 23:25:39.000000000 +1000
+++ /data/Work/IT/CiviCRM/Local/4.4.beta4/civicrm/./packages/html2text/rcube_html2text.php 2013-10-15 10:45:15.469465000 +1100
@@ -524,7 +524,8 @@
             return $display;
         }
 
-        if (preg_match('!^([a-z][a-z0-9.+-]+:)!i', $link)) {
+        if (preg_match('!^([a-z][a-z0-9.+-]+:)!i', $link)
+            || substr($link, 0, 1) == '{') {
             $url = $link;
         }
         else {

Here's a better patch that doesn't require the html2text package to be patched

--- /data/Download/CiviCRM/civicrm-4.4.beta4-drupal/CRM/Utils/String.php 2013-10-02 23:25:16.000000000 +1000
+++ /var/www/citybibleforum/sites/all/modules/civicrm/CRM/Utils/String.php 2013-10-27 22:44:28.214427508 +1100
@@ -410,8 +410,11 @@
    */
   static function htmlToText($html) {
     require_once 'packages/html2text/rcube_html2text.php';
-    $converter = new rcube_html2text($html);
-    return $converter->get_text();
+    $token_html = preg_replace('!\{([a-z.]+)\}!i', 'token:{$1}', $html);
+    $converter = new rcube_html2text($token_html);
+    $token_text = $converter->get_text();
+    $text = preg_replace('!token\:\{([a-z.]+)\}!i', '{$1}', $token_text);
+    return $text;
   }
 
   static function extractName($string, &$params) {

What this does is ...

• Convert tokens in the HTML to a format html2text thinks is an absolute URL ("{action.unsubscribeUrl}" -> "token:{action.unsubscribeUrl}")
• Run html2text over that
• Convert the Text to undo the first step ("token:{action.unsubscribeUrl}" -> "{action.unsubscribeUrl}")
• Return the Text

Can someone who knows the token code better than I check ...

• The regular expressions for recognising tokens are OK
• The change doesn't interfere with other parts of the HTML (eg, "{" in CSS)

Ken,

Can you please file an issue and then submit a PR in github for this.

Thanks
Kurund

I haven't tried a text-only email.

Our emails have ...

• A subject header
• A html part that we edit when sending the email
• A text part that's generated from the html part

understood - what i meant was when the text version created by html2text is received and viewed as text only - as well as missing tokens, is it missing the subject?

all we know is client had a couple of 'my email didn't have any data in the tokens' and in both cases what they forwarded also had the <br /> so assuming at this point their mail clients only show them text only - but we also noted that in both cases the subject was blank - when we know the html one was fine - hence the tiny thread connecting two issues