CiviCRM Community Forums (archive)

On /civicrm/contact/view I used to see the 'Edit' button, but after upgrading to 4.4 it's missing.

Here is a patch to /templates/CRM/Contact/Page/View/Summary.tpl that fixes the issue, but perhaps not completely.

--- /data/Download/CiviCRM/civicrm-4.4.2-drupal/templates/./CRM/Contact/Page/View/Summary.tpl 2013-11-21 16:11:12.000000000 +1100
+++ /data/Work/IT/CiviCRM/Local/4.4.2/cbf/templates/./CRM/Contact/Page/View/Summary.tpl 2013-11-22 23:13:02.895351758 +1100
@@ -58,7 +58,7 @@
             </li>
           {/if}
           {* Include Edit button if contact has 'edit contacts' permission OR user is viewing their own contact AND has 'edit my contact' per
mission. *}
-          {if $permission EQ 'edit' && call_user_func(array('CRM_Core_Permission','check'), 'edit my contact')}
+          {if $permission EQ 'edit' || call_user_func(array('CRM_Core_Permission','check'), 'edit my contact')}
             <li>
               {assign var='editParams' value=$urlParams|cat:"&action=update&cid=$contactId"}
               <a href="{crmURL p='civicrm/contact/add' q=$editParams}" class="edit button" title="{ts}Edit{/ts}">
The comment says OR but the code says AND, and fixing the code makes the button appear. My concern is that this check confirms I have the 'edit my contact' permission, but not that this is MY contact record. I assume the PHP code checks this.

Would you like me to roll a PR?

Ken,

Can you please submit a PR for this against 4.4 branch ( and also file an issue for the same )

Thanks
Kurund

Is the protocol still
    Forum topic --> Issue --> PR

I personally like this flow

Kurund