CiviCRM Community Forums (archive)

*

News:

Have a question about CiviCRM?
Get it answered quickly at the new
CiviCRM Stack Exchange Q+A site

This forum was archived on 25 November 2017. Learn more.
How to get involved.
What to do if you think you've found a bug.



  • CiviCRM Community Forums (archive) »
  • Discussion »
  • Extensions (Moderators: mathieu, totten, kasiawaka) »
  • [solved] CiviDiscount Error after update to 2.5
Pages: 1 [2]

Author Topic: [solved] CiviDiscount Error after update to 2.5  (Read 2663 times)

Carolyn Shannon

  • I’m new here
  • *
  • Posts: 25
  • Karma: 3
  • CiviCRM version: 4.4.6
  • CMS version: Drupal 7
  • MySQL version: 5.1.54
  • PHP version: 5.3.5
Re: [solved] CiviDiscount Error after update to 2.5
May 15, 2014, 04:04:18 pm
So, when upgrading an extension using a Github download, do I need to uninstall, or do I disable/replace code/enable, or something else?

Sorry, not sure what to do here.

Eileen

  • Forum Godess / God
  • I’m (like) Lobo ;)
  • *****
  • Posts: 4195
  • Karma: 218
    • Fuzion
Re: [solved] CiviDiscount Error after update to 2.5
May 15, 2014, 04:22:34 pm
Delete the code & replace it with the code from git. On the extensions screen you should see an upgrade button. Try it on a dev site as that code is not released as a formal release yet
Make today the day you step up to support CiviCRM and all the amazing organisations that are using it to improve our world - http://civicrm.org/contribute

Carolyn Shannon

  • I’m new here
  • *
  • Posts: 25
  • Karma: 3
  • CiviCRM version: 4.4.6
  • CMS version: Drupal 7
  • MySQL version: 5.1.54
  • PHP version: 5.3.5
Re: [solved] CiviDiscount Error after update to 2.5
May 19, 2014, 07:54:54 pm
Spun up a copy of the site, upgraded the discount module. Now the discount field doesn't show up on the civievent form and I get this error msg in the cividiscount config screen:

User error: Smarty error: [in CRM/CiviDiscount/Form/Admin.tpl line 138]: syntax error: expecting '=' after attribute name 'discounts' (Smarty_Compiler.class.php, line 1591) in Smarty->trigger_error() (line 1094 of [sites/all/modules directory path]/civicrm/packages/Smarty/Smarty.class.php).

Edited to add: After creating one new discount, the error has gone away. But there is still no discount field on the event registration form (or membership form, which also has discounts). Ideas?
« Last Edit: May 20, 2014, 03:22:55 am by Carolyn Shannon »

Eileen

  • Forum Godess / God
  • I’m (like) Lobo ;)
  • *****
  • Posts: 4195
  • Karma: 218
    • Fuzion
Re: [solved] CiviDiscount Error after update to 2.5
May 23, 2014, 01:55:34 am
So - the version on the main git repo as 'master' or 2.6 now only supports 4.5

The same version for 4.4 is here https://github.com/eileenmcnaughton/org.civicrm.module.cividiscount/tree/4.4

I just fixed a problem whereby events will null end dates weren't getting discounts & also ( not committed) suppressed the code box when the code is already auto-applied
Make today the day you step up to support CiviCRM and all the amazing organisations that are using it to improve our world - http://civicrm.org/contribute

Carolyn Shannon

  • I’m new here
  • *
  • Posts: 25
  • Karma: 3
  • CiviCRM version: 4.4.6
  • CMS version: Drupal 7
  • MySQL version: 5.1.54
  • PHP version: 5.3.5
Re: [solved] CiviDiscount Error after update to 2.5
May 26, 2014, 03:52:23 pm
In my case it looks like if I enable the new field "Display a message to users not eligible for this discount?" any valid discount that could be entered gives the "not eligible" text. I'm wondering if there is something new or not working quite right with the eligibility calculator that is causing the discount code field to go away.

Any ideas?
« Last Edit: May 28, 2014, 03:57:28 am by Carolyn Shannon »

Eileen

  • Forum Godess / God
  • I’m (like) Lobo ;)
  • *****
  • Posts: 4195
  • Karma: 218
    • Fuzion
Re: [solved] CiviDiscount Error after update to 2.5
May 26, 2014, 04:09:59 pm
Can you confirm which version you are using?
Make today the day you step up to support CiviCRM and all the amazing organisations that are using it to improve our world - http://civicrm.org/contribute

Carolyn Shannon

  • I’m new here
  • *
  • Posts: 25
  • Karma: 3
  • CiviCRM version: 4.4.6
  • CMS version: Drupal 7
  • MySQL version: 5.1.54
  • PHP version: 5.3.5
Re: [solved] CiviDiscount Error after update to 2.5
May 28, 2014, 03:56:53 am
I've upgraded to CiviCRM 4.4.5 and the 4.4 version you indicated. I've added start and end dates for discounts. I am using a price set with an early-bird discount applied only to conference registration, and discount codes one can enter manually for pre-conference session registration items in the price set.

I'm really confounded by this - we have an active site with the 2.5 version that shows the discount field and applies discount codes properly, but incorrectly applies any automatic discount codes to everything in the price set. And a copy of the site with your 4.4 version which correctly applies auto-discounts but doesn't show the discount code field and says a registrant is not eligible for any of the discount codes when the "display message" flag is checked.

We really want to use this module, but it's just not working correctly. Any suggestions?

Thanks for your help!

Eileen

  • Forum Godess / God
  • I’m (like) Lobo ;)
  • *****
  • Posts: 4195
  • Karma: 218
    • Fuzion
Re: [solved] CiviDiscount Error after update to 2.5
June 05, 2014, 03:58:23 am
Hi - I've put some fixes in that repo now. Do you want to update from there & try

Make today the day you step up to support CiviCRM and all the amazing organisations that are using it to improve our world - http://civicrm.org/contribute

sonicthoughts

  • Ask me questions
  • ****
  • Posts: 498
  • Karma: 10
Re: [solved] CiviDiscount Error after update to 2.5
January 07, 2015, 02:43:39 pm
Just to chime in here (I know it is an old topic) I just added cividiscount 3.0, enabled for an event and didn't specify a price set field.  The code would not apply to the total.  If I add the price set field it does add to the total.  Should the price set field be required?  I assumed that omitting it would apply to the total amount.  Will cross-post this on github.

Pages: 1 [2]
  • CiviCRM Community Forums (archive) »
  • Discussion »
  • Extensions (Moderators: mathieu, totten, kasiawaka) »
  • [solved] CiviDiscount Error after update to 2.5

This forum was archived on 2017-11-26.