CiviCRM Community Forums (archive)

*

News:

Have a question about CiviCRM?
Get it answered quickly at the new
CiviCRM Stack Exchange Q+A site
This forum was archived on 25 November 2017. Learn more.
How to get involved.
What to do if you think you've found a bug.



  • CiviCRM Community Forums (archive) »
  • Discussion »
  • Extensions (Moderators: mathieu, totten, kasiawaka) »
  • [solved] CiviDiscount Error after update to 2.5
Pages: [1] 2

Author Topic: [solved] CiviDiscount Error after update to 2.5  (Read 2663 times)

Anthony F. Camilleri

  • I post occasionally
  • **
  • Posts: 51
  • Karma: 2
  • CiviCRM version: 4.4.3
  • CMS version: wordpress
  • MySQL version: 5.1
  • PHP version: 4.3
[solved] CiviDiscount Error after update to 2.5
December 03, 2013, 07:24:07 am
Hi all,

I recently updated CiviDiscount to 2.5. However, a discount code which is only set to apply to certain cost-items of the event (registration fees), is being applied to everything in the event.

I am attaching two screenshots, showing my settings and the effect on the event. Any ideas?

Sincerely,

Anthony
« Last Edit: February 03, 2014, 04:26:43 am by anthonycamilleri »

phunter

  • I’m new here
  • *
  • Posts: 29
  • Karma: 0
  • CiviCRM version: Latest
  • CMS version: Drupal 7
Re: CiviDiscount Error after update to 2.5
December 18, 2013, 03:28:08 pm
I have notice the same issue and just making sure my understanding is correct.
My assumption is that if you create a priceset and add an items that has 2 or more select items you can choose to apply the discount to just one of these items. The Discount setup seems to suggest this but when one of the items is selected for the discount then the discount is applied to all items. Is there a solution to this at the moment? I am assuming it also worked in the previous version (2.3/2.4)?

Anthony F. Camilleri

  • I post occasionally
  • **
  • Posts: 51
  • Karma: 2
  • CiviCRM version: 4.4.3
  • CMS version: wordpress
  • MySQL version: 5.1
  • PHP version: 4.3
Re: CiviDiscount Error after update to 2.5
January 27, 2014, 05:49:42 am
Just a one-liner to push the topic again - is anyone else having similar problems and/or have a solution?

Donald Lobo

  • Administrator
  • I’m (like) Lobo ;)
  • *****
  • Posts: 15963
  • Karma: 470
    • CiviCRM site
  • CiviCRM version: 4.2+
  • CMS version: Drupal 7, Joomla 2.5+
  • MySQL version: 5.5.x
  • PHP version: 5.4.x
Re: CiviDiscount Error after update to 2.5
January 27, 2014, 07:59:26 am

If i had to guess this might have broke in the 2.x series

would be great if someone can investigate the code and submit a PR for this

thanx

lobo
A new CiviCRM Q&A resource needs YOUR help to get started. Visit our StackExchange proposed site, sign up and vote on 5 questions

phunter

  • I’m new here
  • *
  • Posts: 29
  • Karma: 0
  • CiviCRM version: Latest
  • CMS version: Drupal 7
Re: CiviDiscount Error after update to 2.5
February 01, 2014, 09:48:35 am
Our development team may have a fix for this. I will confirm as soon as possible

Rajesh

  • I post occasionally
  • **
  • Posts: 78
  • Karma: 10
  • CiviCRM version: 4.2.x, 4.3.x, 4.4.x
  • CMS version: Drupal 7.xx, Wordpress 3.5.x - 3.6.x, Joomla 3.1
  • MySQL version: 5.5.20
  • PHP version: 5.3.10
Re: CiviDiscount Error after update to 2.5
February 03, 2014, 02:22:22 am
Please try the atttached patch to see it this fixes the problem.

Thanks
Rajesh

Anthony F. Camilleri

  • I post occasionally
  • **
  • Posts: 51
  • Karma: 2
  • CiviCRM version: 4.4.3
  • CMS version: wordpress
  • MySQL version: 5.1
  • PHP version: 4.3
Re: CiviDiscount Error after update to 2.5
February 03, 2014, 04:25:43 am
I've tried out the patch, and I can confirm it is working on latest version of Civi on two separate installations. Thanks!

Donald Lobo

  • Administrator
  • I’m (like) Lobo ;)
  • *****
  • Posts: 15963
  • Karma: 470
    • CiviCRM site
  • CiviCRM version: 4.2+
  • CMS version: Drupal 7, Joomla 2.5+
  • MySQL version: 5.5.x
  • PHP version: 5.4.x
Re: [solved] CiviDiscount Error after update to 2.5
February 03, 2014, 07:54:40 am

rajesh:

can u please submit that as a PR against the cividiscount github

thanx

lobo
A new CiviCRM Q&A resource needs YOUR help to get started. Visit our StackExchange proposed site, sign up and vote on 5 questions

Rajesh

  • I post occasionally
  • **
  • Posts: 78
  • Karma: 10
  • CiviCRM version: 4.2.x, 4.3.x, 4.4.x
  • CMS version: Drupal 7.xx, Wordpress 3.5.x - 3.6.x, Joomla 3.1
  • MySQL version: 5.5.20
  • PHP version: 5.3.10
Re: [solved] CiviDiscount Error after update to 2.5
February 03, 2014, 09:01:16 am
Submitted PR against the cividiscount github.

- Rajesh

GinkgoDOB

  • I post occasionally
  • **
  • Posts: 54
  • Karma: 1
  • Dir. of Product Development, Ginkgo Street Labs
    • Ginkgo Street Labs
  • CiviCRM version: v4.5-4.7
  • CMS version: Drupal
Re: [solved] CiviDiscount Error after update to 2.5
February 03, 2014, 12:46:17 pm
I've put this in on a demo system and a customer's site and it appears to work.

Thanks so much for you work on this.

Dan

penguintrax

  • I post frequently
  • ***
  • Posts: 230
  • Karma: 2
  • CiviCRM version: 3.3x and 4.x depending on site
  • CMS version: Joomla 1.5 or 1.7 depending on site
  • MySQL version: 5.0.92-community
  • PHP version: 5.2.17
Re: [solved] CiviDiscount Error after update to 2.5
March 18, 2014, 10:18:45 am
I applied this patch and the discount is still being applied to all registrations, not just the first one.

Civi 4.3.5
Joomla 2.5.19
CiviDiscount 2.5

Carolyn Shannon

  • I’m new here
  • *
  • Posts: 25
  • Karma: 3
  • CiviCRM version: 4.4.6
  • CMS version: Drupal 7
  • MySQL version: 5.1.54
  • PHP version: 5.3.5
Re: [solved] CiviDiscount Error after update to 2.5
May 14, 2014, 08:07:05 pm
This doesn't seem to be fixed. I've pulled the most recent code from Github and automatic discounts are still being applied across all items in a price set, not just the ones specified in the discount setup.

Do I need to un-install and re-install? What are others doing to make this work?

Civi 4.4.4
Drupal 7
CiviDiscount 2.5

Eileen

  • Forum Godess / God
  • I’m (like) Lobo ;)
  • *****
  • Posts: 4195
  • Karma: 218
    • Fuzion
Re: [solved] CiviDiscount Error after update to 2.5
May 15, 2014, 02:42:00 am
Hmm - I could have sworn the most recent from github was fixed for this - are you seeing the screen with the extra options (by age, country etc)
Make today the day you step up to support CiviCRM and all the amazing organisations that are using it to improve our world - http://civicrm.org/contribute

Carolyn Shannon

  • I’m new here
  • *
  • Posts: 25
  • Karma: 3
  • CiviCRM version: 4.4.6
  • CMS version: Drupal 7
  • MySQL version: 5.1.54
  • PHP version: 5.3.5
Re: [solved] CiviDiscount Error after update to 2.5
May 15, 2014, 06:27:34 am
Hi Eileen,
Maybe I updated this incorrectly. Since 2.5 is the most recent version, I don't get an "update" button on my extensions panel. But when I looked at the codebase installed for 2.5 it didn't include the most recent changes from Github. So I disabled the module, replaced the code with the code from Github, and re-enabled. Should I have done something different?

I appreciate your help!

Eileen

  • Forum Godess / God
  • I’m (like) Lobo ;)
  • *****
  • Posts: 4195
  • Karma: 218
    • Fuzion
Re: [solved] CiviDiscount Error after update to 2.5
May 15, 2014, 03:14:16 pm
Sorry - I incorrectly thought my branch had been merged into the main branch - pretty sure it's fixed in my branch - but it'a major overhaul - among other things it includes 'freeform' automatic discounts - see pic & readme.

https://github.com/eileenmcnaughton/org.civicrm.module.cividiscount/tree/extended_filters

Give this one a try (in a dev environment as it does have an upgrade script & alters a field)
Make today the day you step up to support CiviCRM and all the amazing organisations that are using it to improve our world - http://civicrm.org/contribute
Pages: [1] 2
  • CiviCRM Community Forums (archive) »
  • Discussion »
  • Extensions (Moderators: mathieu, totten, kasiawaka) »
  • [solved] CiviDiscount Error after update to 2.5

This forum was archived on 2017-11-26.