CiviCRM Community Forums (archive)

I'm working on an extension to provide SMS via the NHS.net email->SMS gateway.

Currently I'm seeing odd behaviour in Civi, and I can't tell if it is intended, or a bug.

When a recipient is designated who does not have a mobile phone number they will not be sent a message. This makes sense. But if they do have a mobile, but it isn't marked as their primary phone, then Civi includes them in the attempts but doesn't supply the necessary variables to send() so I don't think it can be working.

Example:

Three contacts fit some search criteria. The first has '1111111111' as their home mobile, marked as primary. The second has '2222222222' as their home mobile, and '3333333333' as their home landline, marked as primary. The third has '4444444444' as their home landline, marked as primary.

Expected behaviour - two SMS messages should be sent, one to 1111111111111 and one to 2222222222 (the two mobile numbers available).

Actual behaviour - correctly, CiviCRM tells me "SMS will not be sent to 1 contact", and it sets up the Send SMS form with 1111111111 and 2222222222 as the intended recipients. It says "2 messages were sent successfully". BUT ... here is the result of outputting the various supplied variables to the send() function:

First pass:

$recipient: 1111111111

$header:
Array
(
    [qfKey] => c6e706fb05060a9b056736c31450d150_1841
    [entryURL] => http://localhost/drupal-7.15/civicrm/contact/search?reset=1
    [to] => 488::1111111111,486::2222222222
    [activity_subject] => TEST 2 - more array exploding
    [sms_provider_id] => 3
    [token3] => Array
        (
        )

    [token1] => Array
        (
        )

    [token2] => Array
        (
        )

    [template] => 60
    [saveTemplateName] =>
    [MAX_FILE_SIZE] => 2097152
    [provider_id] => 3
    [To] => 1111111111
    [contact_id] => 488
    [parent_activity_id] => 1533
)

$message: THIS IS THE TEST TEXT

$job ID:


Second pass:

$recipient:

$header:
Array
(
    [qfKey] => c6e706fb05060a9b056736c31450d150_1841
    [entryURL] => http://localhost/drupal-7.15/civicrm/contact/search?reset=1
    [to] => 488::1111111111,486::2222222222
    [activity_subject] => TEST 2 - more array exploding
    [sms_provider_id] => 3
    [token3] => Array
        (
        )

    [token1] => Array
        (
        )

    [token2] => Array
        (
        )

    [template] => 60
    [saveTemplateName] =>
    [MAX_FILE_SIZE] => 2097152
    [provider_id] => 3
    [To] =>
    [contact_id] => 486
    [parent_activity_id] => 1533
)

$message: THIS IS THE TEST TEXT

$jobID:


Note how both contact IDs and both mobile numbers show up in $header['to'], but only one gets passed as $recipient, and $header['To'] - and since this is what the clickatell exension uses to actually send the text messages, it seems to me that the extension should be failing to send to any mobile number not marked as primary.

I suppose it is possible that the intended behaviour is to only text people who have set their mobile as their primary number, but just because I want people to voice call me on my landline doesn't mean I don't want to receive text messages on my mobile, does it?

Looking at CRM/Activity/BAO/Activity.php I think the problem is that the sendSMS() function sets $smsParams['To'] to be blank if the supplied primary phone number for the contact is not a mobile, or to the phone number if it is a mobile, and then the sendSMSMessage() function 'fixes' this by looking up all the phone numbers for contacts where $smsParams['To'] is blank. However, when it finds the mobile number it doesn't write it back in $smsParams['To'], it puts it into a new variable called $toPhoneNumber - which is never passed to the provider send() function!

So, unless I've misread something (entirely possible), CiviSMS is not correctly sending messages to contacts who have their mobile number not set as primary, unless the provider extensions are adding a supplementary fix in cases where $smsParams['To'] is blank. I don't think they are, and I don't think they should have to.

Are clickatell users not seeing lots of errors?

Our provider extension for NHS mail gateway works a lot better, when the value in $toPhoneNumber is also assigned back in to the empty $smsParams['To']. YMMV.

Line 1505, CRM/Activity/BAO/Activity.php
        $smsParams['To'] = $toPhoneNumber = CRM_Utils_Array::value('phone', $toPhoneNumerDetails); // Adding value back into smsParams again



Nick

When a contact has a mobile number which is not the primary, bulk SMS messages go out just fine.   But, if I am looking at the contact's record and click the "Actions" button the action "Send SMS" is missing.

Also, what if I send a bulk SMS message to a contact who has more than one mobile number?  Does it send to all their mobile numbers?