CiviCRM Community Forums (archive)

*

News:

Have a question about CiviCRM?
Get it answered quickly at the new
CiviCRM Stack Exchange Q+A site

This forum was archived on 25 November 2017. Learn more.
How to get involved.
What to do if you think you've found a bug.



  • CiviCRM Community Forums (archive) »
  • Old sections (read-only, deprecated) »
  • Developer Discussion (Moderator: Donald Lobo) »
  • Soft Credit Limit
Pages: [1]

Author Topic: Soft Credit Limit  (Read 756 times)

Max Hunter

  • I’m new here
  • *
  • Posts: 21
  • Karma: 1
  • CiviCRM version: 4.4.x
  • CMS version: Drupal 7
Soft Credit Limit
February 27, 2014, 01:38:56 pm
Hi All,

Kudos to everyone who did the great work on the improved soft credit functionality.  I wanted to check in and see whether there was any reason that we're limiting soft credit blocks to 5 when creating contributions.

Mid-sized to large nonprofits often receive employer match donations that need to have soft credits distributed across 20-80 employee contact records.  I've patched softcredit.php to lift the 5 contact limit for the Electronic Frontier Foundation; is there any reason we shouldn't do the same in core?

Donald Lobo

  • Administrator
  • I’m (like) Lobo ;)
  • *****
  • Posts: 15963
  • Karma: 470
    • CiviCRM site
  • CiviCRM version: 4.2+
  • CMS version: Drupal 7, Joomla 2.5+
  • MySQL version: 5.5.x
  • PHP version: 5.4.x
Re: Soft Credit Limit
February 27, 2014, 05:18:07 pm

can you patch it to make it a setting (with a default of 5) rather than a really high limit. I've not seen that code, so maybe there is no performance impact with a high limit.

lobo
A new CiviCRM Q&A resource needs YOUR help to get started. Visit our StackExchange proposed site, sign up and vote on 5 questions

joanne

  • Administrator
  • Ask me questions
  • *****
  • Posts: 852
  • Karma: 83
  • CiviCRM version: 4.4.16
  • CMS version: Drupal 7
Re: Soft Credit Limit
December 30, 2014, 08:46:21 pm
I would like to second Max's suggestion that the limit to the number of soft credits be set at a higher number (either a very high number, or at least a reasonably high number (say 20)).

We have started using soft credits for the situation where a local group collects cash for memberships at a local group meeting and then sends us one cheque covering mulitple memberships.

This lets us enter the cheque against the group record and thus generate a bank deposit slip by running a report.

We have been doing this for about 6 months now and haven't yet hit the problem of cheque covering more than 5 memberships, but I am sure it will happen (we often get cheques covering 5 memberships). This means that the limit of 5 soft credits per contribution is sure to become an issue for us.

What is the rationale between only allowing 5 soft credits per contribution?  In at least some other places where traditionally there has been a lowish (10) limit to the number of  items that can be created (eg for price field options) the limit has been removed ( or perhaps set to a higher number).

The idea of making the number of allowed soft credits a setting is appealing I suppose, but it would seem to involve a lot of work for something that could be changed in a two(?) line PR.  (To do it properly one would need a CiviContribute Component Settings page similar to the CiviMember Component Settings page for setting the Default Online Membership Renewal Page).

If there is an unacceptable performance hit for some organisations if the number of soft credits is really high, then surely that should be addressed by organisation rules rather than by an arbitratily imposed limit in CiviCRM.

joanne

  • Administrator
  • Ask me questions
  • *****
  • Posts: 852
  • Karma: 83
  • CiviCRM version: 4.4.16
  • CMS version: Drupal 7
Re: Soft Credit Limit
January 09, 2015, 05:20:31 am
We have hit this problem now.  I have created https://issues.civicrm.org/jira/browse/CRM-15802.     

I can't see the advantage to having this as a configurable setting.  If you have one contribution with one invoice id or transaction id that needs to be soft credited to 100 contacts, then that is what you need to do.  Whether or not there is a performance hit when processing that contribution is actually irrelevant.

I think I have just talked myself into wanting to remove the limit altogether, even though that will mean a more complicated PR.
« Last Edit: January 09, 2015, 05:39:55 am by joanne »

joanne

  • Administrator
  • Ask me questions
  • *****
  • Posts: 852
  • Karma: 83
  • CiviCRM version: 4.4.16
  • CMS version: Drupal 7
Re: Soft Credit Limit
January 09, 2015, 07:52:12 pm
It is always a little dangerous to be too definite about anything when I have so little technical knowledge about CiviCRM. 

Although I still think no limit would be better if it can be done, now that I understand more about how the current form works I can see the reason for a configurable limit. (Sorry Lobo  :-[ )

 

Pages: [1]
  • CiviCRM Community Forums (archive) »
  • Old sections (read-only, deprecated) »
  • Developer Discussion (Moderator: Donald Lobo) »
  • Soft Credit Limit

This forum was archived on 2017-11-26.