CiviCRM Community Forums (archive)

Hi,

In general, I use sequential=>1 as a param, so instead of

$uf_user = $userID['values'];
    foreach($uf_user as $User){
       // Get Contact ID
       $user_id = $User['contact_id'];
     }
   
I can do $user_id = $uf_user["values"][0];

same goes when you fetch the contacts.

You can as well use getsingle, where if you have 0 or more than 1 results, it will raise an error. (it saves you a test isset($bla["values"])

On both calls, you don't see how you process your errors. I don't think there is any "normal" case where a user hasn't a uf_match or a contact in uf_match hasn't a contact record. I wouldn't try to catch it and violently crash if it happens, unless you have a dead solid error handler further down the code.

You could test on the contactID, but the try/catch block should handle that. I also think the object-oriented calls are now easier to use, but that's a matter of preference.

The error clause looks good.

A couple things which may go without saying, but since you wanted confirmation:

1. The good thing is that there's one try{...}catch{...} block, and all the calls to civicrm_api3() are in the try{...} section.
2. The indentation looks a bit wonky in my browser.
3. The "output" is that $error contains the error message, but the code snippet doesn't show how it gets onto the screen (eg via "echo", "print", "drupal_set_message()", "theme()", etc). It shouldn't matter how it gets displayed, but it should get displayed somehow.