CiviCRM Community Forums (archive)

Hi All,

When two contacts with memberships of the same type are merged and the "memberships" box is checked on the merge form, contributions that were recorded as membership payments will be dropped from the "duplicate" contact.

EFF first started to notice this behavior around 4.2.  It is reproducible on the Drupal demo site.  Should I open a JIRA ticket?

Max

So it looks like this bit of code was the culprit:

if ($mode == 'payment') {
        $sqls[] = "
DELETE contribution.* FROM civicrm_contribution contribution
INNER JOIN  civicrm_membership_payment payment ON payment.contribution_id = contribution.id
INNER JOIN  civicrm_membership membership1 ON membership1.id = payment.membership_id
            AND membership1.contact_id = {$mainId}
INNER JOIN  civicrm_membership membership2 ON membership1.membership_type_id = membership2.membership_type_id
            AND membership2.contact_id = {$otherId}";
      }     
Seems to be designed to clean up contributions from membership_payment.  We could remove it outright, but then people wouldn't be able to copy memberships on merge without copying membership related contributions. 

Is there an edge case where someone would want to keep memberships and drop the payment data for them?  What do you think?