Author Topic: activityId for case activities in postProcess hook (CRM-9590 but for cases) (Read 475 times)

demeritcowboy · April 26, 2014, 08:50:47 am

I'm running into the same problem as CRM-9590 but for case activities. There's no way to get the activity id of a newly created activity in the postProcess hook. The difference on the case side is the revisioning logic, and I expect there is code out there that uses the fact that $form->_activityId is blank to tell create vs. edit. So instead of just setting _activityId, I'd propose adding a line to the very bottom of CRM_Case_Form_Activity::postProcess() that sets a different variable, like

$this->_currentRevisionActivityId = $activity->id

and then $form->_currentRevisionActivityId can be used in postProcess hooks.

Or am I missing an easier way to get the id? There is hook_post, but I need to get at the form data so want to do it in postProcess.

Erik Hommel · April 27, 2014, 03:32:19 am

I know the problem, I tend to circumnavigate it by doing a SELECT MAX(id) from the table?

jaapjansma · April 28, 2014, 06:57:01 am

Issue #9590 seems to be fixed in version 4.1.0 so it looks the fix dissappeared!

demeritcowboy · April 28, 2014, 09:56:48 am

I think it works fine for non-case activities, it was just never addressed for case activities.

But I'm suggesting that adding the exact same fix for case activities might cause problems because of the extra complications of revisioning.

The workaround of max(id) will probably work 99.9% of the time, but in the situation where I want to do this that 0.1% of the time where it gives the wrong id would lead to database corruption, so I don't want to rely on it.

CiviCRM Community Forums (archive)

News:

Author Topic: activityId for case activities in postProcess hook (CRM-9590 but for cases) (Read 475 times)

demeritcowboy

activityId for case activities in postProcess hook (CRM-9590 but for cases)

Erik Hommel

Re: activityId for case activities in postProcess hook (CRM-9590 but for cases)

jaapjansma

Re: activityId for case activities in postProcess hook (CRM-9590 but for cases)

demeritcowboy

Re: activityId for case activities in postProcess hook (CRM-9590 but for cases)