CiviCRM Community Forums (archive)

Have you added db alias for civicrm db in settings.php ?

Kurund

kennedy - does the same link work in civi - i ask because in general i find that you cannot just go to an activity to edit it in civi - you also need eg the ID of the contact assigned etc

i think the only way i have been able to jump in to edit and activity is to do it via the ever useful WebformCivicrm module

I might be barking up the wrong tree - if the link you want to create in VIews does work in civi then guess the civi-views code needs looking at.

kennedy i think we might be saying the same thing - but i didn't explain it well

the workaround you provided, or something similar, is what i expected is required since i thought you needed to have the ID and the CID etc, and no single Views field can give that as far as i can see, because it won't have that context.

ie in past i didn't think you could eg 'edit' an activity without a url that includes cid in it

but my quick test just now showed i did get there without the cid in which case a tweak to the views code might suffice (not offering though)
if there is then yes perhaps the views code can cope with that

but if not, then perhaps the 'text link' can be removed from the Views field so others don't get false expectations.

(not sure i am being very articulate but have rewritten this three times now - sorry)

I have found the fix for this and will submit a patch in the next few days. For anyone finding this page while searching for a fix, here's the answer:

the heavy lifting of doing the necessary join to the table introduced in 4.4 was already done, but civicrm_handler_field_link_activity.inc was still calling the pre 4.4 schema/looking for a column in the db that no longer exists.

so, first, comment out or delete line 49
    //  $this->additional_fields['contact_id'] = 'contact_id';

then change the link to use
cid={$values->civicrm_contact_civicrm_activity_contact_id}
instead of
cid={$values->civicrm_activity_source_contact_id}

on lines 114, 123 and 132

your links should be correctly formatted and no longer throw errors

I'm guessing the reason why it works in some cases and not all is that the edit link needs the CID of the activity source and not the CID of the record in the current row of the view. (it will work when that row happens to be pertaining to the activity source) - the source is now identified through the 'Record Type' attribute of Activity Contacts rather than as an attribute of Activity.

I was thinking of using a views_php field as a workaround but then I realised that my view filters out the source of the activity 

and from this issue it seems that this problem will be resolved in 4.6
https://issues.civicrm.org/jira/browse/CRM-15008

note Jira is unresolved - fix for 4.7 - ericg can you supply your patch as a PR?