CiviCRM Community Forums (archive)

*

News:

Have a question about CiviCRM?
Get it answered quickly at the new
CiviCRM Stack Exchange Q+A site
This forum was archived on 25 November 2017. Learn more.
How to get involved.
What to do if you think you've found a bug.



  • CiviCRM Community Forums (archive) »
  • Old sections (read-only, deprecated) »
  • Support »
  • Using CiviCRM »
  • Using Core CiviCRM Functions (Moderator: Yashodha Chaku) »
  • Multiple custom records - limit not working [FIXED]
Pages: [1]

Author Topic: Multiple custom records - limit not working [FIXED]  (Read 483 times)

clarkac

  • Administrator
  • Ask me questions
  • *****
  • Posts: 399
  • Karma: 11
  • CiviCRM version: 4.4.11 & 4.5.5
  • CMS version: Drupal 7
  • MySQL version: 5.1.61-cll
  • PHP version: 5.3.27
Multiple custom records - limit not working [FIXED]
July 21, 2014, 11:14:26 am
I set up a custom field set, allowing multiple records and setting a limit of 3 records.  However, this limit is not enforced at all.  This is reproducible on the 4.4 sandbox (see custom group temp for a parent contact, if it's still there).  Any comments before I raise this is an issue?
« Last Edit: July 25, 2014, 12:31:40 am by clarkac »
Andy Clark

Dave Greenberg

  • Administrator
  • I’m (like) Lobo ;)
  • *****
  • Posts: 5760
  • Karma: 226
    • My CiviCRM Blog
Re: Multiple custom records - limit not working
July 21, 2014, 11:16:50 am
Can you test this in 4.5 to see if it's still not enforced? http://drupal.sandbox.civicrm.org/
Protect your investment in CiviCRM by  becoming a Member!

Coleman Watts

  • Administrator
  • I’m (like) Lobo ;)
  • *****
  • Posts: 2346
  • Karma: 183
  • CiviCRM version: The Bleeding Edge
  • CMS version: Various
Re: Multiple custom records - limit not working
July 21, 2014, 11:45:38 am
When you say not enforced "at all" do you mean in the UI or the api?
Try asking your question on the new CiviCRM help site.

clarkac

  • Administrator
  • Ask me questions
  • *****
  • Posts: 399
  • Karma: 11
  • CiviCRM version: 4.4.11 & 4.5.5
  • CMS version: Drupal 7
  • MySQL version: 5.1.61-cll
  • PHP version: 5.3.27
Re: Multiple custom records - limit not working
July 21, 2014, 11:48:56 am
That was a fast reply!  Yes, 4.5 does restrict the number but gets it wrong.  It allows one more record than is permitted - I stated a max of 3 and it allowed 4.  I tried a max of 2 and it allowed 3.  This is in the UI.

Slightly different point, once you've set this limit there's no way to see what it is.  The custom field set screen should really display this number, shouldn't it?
Andy Clark

Dave Greenberg

  • Administrator
  • I’m (like) Lobo ;)
  • *****
  • Posts: 5760
  • Karma: 226
    • My CiviCRM Blog
Re: Multiple custom records - limit not working
July 22, 2014, 09:50:42 am
Andy - please file an issue for this against 4.5 (both the limit +1 and not displaying the limit when viewing the data set) - and if possible include a pull request against master to correct both.
Protect your investment in CiviCRM by  becoming a Member!

clarkac

  • Administrator
  • Ask me questions
  • *****
  • Posts: 399
  • Karma: 11
  • CiviCRM version: 4.4.11 & 4.5.5
  • CMS version: Drupal 7
  • MySQL version: 5.1.61-cll
  • PHP version: 5.3.27
Re: Multiple custom records - limit not working
July 22, 2014, 10:32:28 am
Issue https://issues.civicrm.org/jira/browse/CRM-15026 raised.  I was wrong about the maximum number not displayed, it is displayed just fine on the custom field set screen.

Sorry, I am not competent to do the pull request.  I'm an ex-developer, now an implementer so not familiar with the technology.  Guess I should learn...
Andy Clark

Dave Greenberg

  • Administrator
  • I’m (like) Lobo ;)
  • *****
  • Posts: 5760
  • Karma: 226
    • My CiviCRM Blog
Re: Multiple custom records - limit not working
July 24, 2014, 05:03:31 pm
Ok - issue has been resolved, fix is https://github.com/civicrm/civicrm-core/pull/3724
Protect your investment in CiviCRM by  becoming a Member!

clarkac

  • Administrator
  • Ask me questions
  • *****
  • Posts: 399
  • Karma: 11
  • CiviCRM version: 4.4.11 & 4.5.5
  • CMS version: Drupal 7
  • MySQL version: 5.1.61-cll
  • PHP version: 5.3.27
Re: Multiple custom records - limit not working
July 25, 2014, 12:31:02 am
Thanks - I just installed 4.5 beta 3 and this now works.
Andy Clark
Pages: [1]
  • CiviCRM Community Forums (archive) »
  • Old sections (read-only, deprecated) »
  • Support »
  • Using CiviCRM »
  • Using Core CiviCRM Functions (Moderator: Yashodha Chaku) »
  • Multiple custom records - limit not working [FIXED]

This forum was archived on 2017-11-26.