CiviCRM Community Forums (archive)

*

News:

Have a question about CiviCRM?
Get it answered quickly at the new
CiviCRM Stack Exchange Q+A site

This forum was archived on 25 November 2017. Learn more.
How to get involved.
What to do if you think you've found a bug.



  • CiviCRM Community Forums (archive) »
  • Old sections (read-only, deprecated) »
  • Support »
  • Using CiviCRM »
  • Using Core CiviCRM Functions (Moderator: Yashodha Chaku) »
  • Deduping Issues
Pages: [1]

Author Topic: Deduping Issues  (Read 2670 times)

lcdweb

  • Forum Godess / God
  • I live on this forum
  • *****
  • Posts: 1620
  • Karma: 116
    • www.lcdservices.biz
  • CiviCRM version: many versions...
  • CMS version: Joomla/Drupal
  • MySQL version: 5.1+
  • PHP version: 5.2+
Deduping Issues
May 23, 2008, 05:23:49 am
Just working through some deduping cleanup and noticed a couple issues that I don't believe should be there --

1) The merge process overwrites all fields in a data block, even if the fields in the duplicate record are empty. For example:
Contact 1 main address contains a phone, email, no address.
Contact 2 main address contains address, no phone or email.

If I merge 2 into 1, I would expect that the address would be brought over, giving me a full data set. Instead, the address is brought over and the phone/email previously recorded in Contact 1 is erased (the lack of data for those values in Contact 2 overwrites the existing values).

I believe the logic should be IF value in 2, overwrite in 1 -- on a field by field basis.

2) Smaller issue, but the terminology in the duplicate comparison screen seems backward. In col 1 it reads "potentially duplicate contact" and when one is selected, col 2 says "merge with". As I read that, col 1 is the duplicate and col 2 is the "real" record. But when you continue to the next screen, that language is reversed -- what was in col 2 is treated as the dup and what was in col 1 is treated as the "real" contact.

Since sometimes a user may choose to selectively merge data blocks, it becomes important to have the logic accurate.

Please confirm behavior and let me know if these should be Jira'd.

-Brian
support CiviCRM through 'make it happen' initiatives!
http://civicrm.org/mih

petednz

  • Forum Godess / God
  • I’m (like) Lobo ;)
  • *****
  • Posts: 4899
  • Karma: 193
    • Fuzion
  • CiviCRM version: 3.x - 4.x
  • CMS version: Drupal 6 and 7
Re: Deduping Issues
May 23, 2008, 01:56:06 pm
Brian - since it is only sometime obvious on the 'merge' page which is the record to keep, (for me at least since that is when the data is actually shown) could it be set up so that you basically have a left and a right column and a button to indicate whether the merge is to put data from 'left' in to 'right' or vice versa?
Sign up to StackExchange and get free expert advice: https://civicrm.org/blogs/colemanw/get-exclusive-access-free-expert-help

pete davis : www.fuzion.co.nz : connect + campaign + communicate

lcdweb

  • Forum Godess / God
  • I live on this forum
  • *****
  • Posts: 1620
  • Karma: 116
    • www.lcdservices.biz
  • CiviCRM version: many versions...
  • CMS version: Joomla/Drupal
  • MySQL version: 5.1+
  • PHP version: 5.2+
Re: Deduping Issues
May 23, 2008, 02:54:30 pm
Valid point --
In the specific instance in which I was working, I knew the "real" records because they all had a prefix. But in most cases, you can't tell the difference.

So yes, a preferred way to handle it would be to have the option of selecting the direction of the merge. That issue is probably pretty small, since either way the records will be merged into a single one. I only noticed the mixup in logic because I actually did know (and care about) which record was the one I was keeping.

I think the first issue is more important to functionality.

-Brian
support CiviCRM through 'make it happen' initiatives!
http://civicrm.org/mih

petednz

  • Forum Godess / God
  • I’m (like) Lobo ;)
  • *****
  • Posts: 4899
  • Karma: 193
    • Fuzion
  • CiviCRM version: 3.x - 4.x
  • CMS version: Drupal 6 and 7
Re: Deduping Issues
May 23, 2008, 03:11:34 pm
Agreed - was just trying to piggy back on your post as it is something I hadn't flagged elsewhere and anything that can make the merge process more deliberate the better.

You spotted the problems with the Location data being merged even when that box was unchecked? hopefully merge will be more reliable soon as team are working on it though think this last point is already fixed
http://forum.civicrm.org/index.php/topic,3260.0.html
Sign up to StackExchange and get free expert advice: https://civicrm.org/blogs/colemanw/get-exclusive-access-free-expert-help

pete davis : www.fuzion.co.nz : connect + campaign + communicate

lcdweb

  • Forum Godess / God
  • I live on this forum
  • *****
  • Posts: 1620
  • Karma: 116
    • www.lcdservices.biz
  • CiviCRM version: many versions...
  • CMS version: Joomla/Drupal
  • MySQL version: 5.1+
  • PHP version: 5.2+
Re: Deduping Issues
May 23, 2008, 03:24:32 pm
No -- not when unchecked. The problem is that if you check one of the "blocks" available in the merge comparison screen, it completely replaces all the fields -- even if that means an empty field overriding existing data.

In my case, I had some phone numbers in the existing location block, and had addresses with no phone numbers in the dup location block. When I merged them, I lost the phone numbers.
support CiviCRM through 'make it happen' initiatives!
http://civicrm.org/mih

Deepak Srivastava

  • Ask me questions
  • ****
  • Posts: 677
  • Karma: 65
Re: Deduping Issues
May 24, 2008, 06:24:14 am
Regarding your first issue - since a location=email+phone+IM+phoneID+address, and merger gives an option to move / merge location and NOT address, you noticed the intended behavior.

Regarding the second, the entire merge screen is being reworked and therfore doesn't apply to 2.1
« Last Edit: May 24, 2008, 06:26:35 am by Deepak Srivastava »
Found this reply helpful? Contribute NOW and help us improve CiviCRM with the Make it Happen! initiative.

petednz

  • Forum Godess / God
  • I’m (like) Lobo ;)
  • *****
  • Posts: 4899
  • Karma: 193
    • Fuzion
  • CiviCRM version: 3.x - 4.x
  • CMS version: Drupal 6 and 7
Re: Deduping Issues
May 24, 2008, 01:51:36 pm
Hi Deepak, If the entire screen is being reworked, it may be relevant still to be asking whether it permits us to define whether we are wanting A to merge with B, or B with A, as sometimes it is only clear when their data becomes visible on the merge screen. Pete
Sign up to StackExchange and get free expert advice: https://civicrm.org/blogs/colemanw/get-exclusive-access-free-expert-help

pete davis : www.fuzion.co.nz : connect + campaign + communicate

Deepak Srivastava

  • Ask me questions
  • ****
  • Posts: 677
  • Karma: 65
Re: Deduping Issues
May 24, 2008, 09:36:15 pm
Quote
whether it permits us to define whether we are wanting A to merge with B, or B with A, as sometimes it is only clear when their data becomes visible on the merge screen.

So in 2.1 merge screen will also provide a "flip" option which will allow you to do that.
« Last Edit: May 24, 2008, 10:19:49 pm by Deepak Srivastava »
Found this reply helpful? Contribute NOW and help us improve CiviCRM with the Make it Happen! initiative.

Deepak Srivastava

  • Ask me questions
  • ****
  • Posts: 677
  • Karma: 65
Re: Deduping Issues
May 25, 2008, 10:27:33 pm
An issue has been filed which will address the first issue (mentioned by Brian) - http://issues.civicrm.org/jira/browse/CRM-3149
« Last Edit: May 26, 2008, 12:08:39 am by Deepak Srivastava »
Found this reply helpful? Contribute NOW and help us improve CiviCRM with the Make it Happen! initiative.

Pages: [1]
  • CiviCRM Community Forums (archive) »
  • Old sections (read-only, deprecated) »
  • Support »
  • Using CiviCRM »
  • Using Core CiviCRM Functions (Moderator: Yashodha Chaku) »
  • Deduping Issues

This forum was archived on 2017-11-26.