CiviCRM Community Forums (archive)

*

News:

Have a question about CiviCRM?
Get it answered quickly at the new
CiviCRM Stack Exchange Q+A site
This forum was archived on 25 November 2017. Learn more.
How to get involved.
What to do if you think you've found a bug.



  • CiviCRM Community Forums (archive) »
  • Old sections (read-only, deprecated) »
  • Developer Discussion (Moderator: Donald Lobo) »
  • Are we misusing PR labels?
Pages: [1]

Author Topic: Are we misusing PR labels?  (Read 319 times)

Coleman Watts

  • Administrator
  • I’m (like) Lobo ;)
  • *****
  • Posts: 2346
  • Karma: 183
  • CiviCRM version: The Bleeding Edge
  • CMS version: Various
Are we misusing PR labels?
November 18, 2014, 06:05:02 am
In GitHub I see 2 ways to classify a PR - "labels" and "milestones". It seems that the purpose of labels is to categorize PRs according to scope, functionality, or something qualitative like that. Milestones seem to be intended to refer to version numbers.

So by that, most of our labels ought to be milestones.
Try asking your question on the new CiviCRM help site.

totten

  • Administrator
  • Ask me questions
  • *****
  • Posts: 695
  • Karma: 64
Re: Are we misusing PR labels?
November 18, 2014, 08:56:04 am
Only a little bit misused...

The issue is that github provides much nicer display of labels than milestones -- when you skim a list of tickets, the labels pop out at you. IIRC, the !milestones either don't show up or appear in subdued text.

Coleman Watts

  • Administrator
  • I’m (like) Lobo ;)
  • *****
  • Posts: 2346
  • Karma: 183
  • CiviCRM version: The Bleeding Edge
  • CMS version: Various
Re: Are we misusing PR labels?
November 18, 2014, 10:09:03 am
Ok that's good enough for me.
Try asking your question on the new CiviCRM help site.
Pages: [1]
  • CiviCRM Community Forums (archive) »
  • Old sections (read-only, deprecated) »
  • Developer Discussion (Moderator: Donald Lobo) »
  • Are we misusing PR labels?

This forum was archived on 2017-11-26.