CiviCRM Community Forums (archive)

As discussed here, we'd like Civi to accept money values when entered with a currency symbol. So I made CRM-16221 to keep track of this fix.

I'm trying to fix it, both because I want the fix for my org, and also because I'm trying to learn more about the code base. (I'm new to developing with Civi.) So I'm trying to really do this fix the right way. No hacks. I want feedback here.

The CRM_Utils_Rule::cleanMoney() function seems like a clear place to apply this fix. I tried changing the first line to read as follows:

$value = str_replace(array(" ", "\t", "\n", "$", "¥", "£"), '', $value);

And this works well. When testing with an amount of "$23", I get to the confirmation screen with no errors. Strange part is that the confirmation screen is the missing the "Contribution Amount", "Billing Name and Details", and "Credit Card Information" sections on the screen. The only sections I have on the confirmation page are the sections generated from data entered through my profile fields for the contribution page.

What is even more strange is that if I test with an amount of "2$3", everything works as expected and I see all sections on the confirmation page.

I'd love some help here. Trying to bridge the gap to become a developer after many years of user/implementer.

try placing those currency symbols in single quotes instead of double

I tried this but it behaved exactly the same. Also tried "\$" (same behavior), and '\$' (which causes my test to fail validation).

I've also watched this function run through a de-bugger and seen $value go from $20 to 20, so it seems to me that the mischief is outside of this function.

Thanks for the tip though! Still curious how to fix this!

Yes, I'm familiar with jQuery and it has occurred to me to approach this issue from that direction. But honestly that feels a bit hack-ish so I'm hesitant to go down that road. Further, since I'm trying to focus my time right now on tasks that help me learn more about the CiviCRM codebase, spending time on the jQuery approach would not be a priority for me, personally. I really want get deeper in to learning how to be a CiviCRM developer. If fixing this issue through the server-side form mechanisms proves too difficult, then I'll move to a different issue that I feel will also help me learn about the inner workings of Civi. Also, just my opinion: In terms of instant feedback to the user (by removing currency symbol), to me this does not seems important if the form would accept values entered with currency symbols.

Still very curious why my original fix caused other problems. Would love to learn how to apply this sort of fix properly!