CiviCRM Community Forums (archive)

*

News:

Have a question about CiviCRM?
Get it answered quickly at the new
CiviCRM Stack Exchange Q+A site
This forum was archived on 25 November 2017. Learn more.
How to get involved.
What to do if you think you've found a bug.



  • CiviCRM Community Forums (archive) »
  • Old sections (read-only, deprecated) »
  • Developer Discussion (Moderator: Donald Lobo) »
  • Another pair of eyes on first pull request
Pages: [1]

Author Topic: Another pair of eyes on first pull request  (Read 446 times)

krypto

  • I post occasionally
  • **
  • Posts: 69
  • Karma: 5
  • IT guy for @bhahumanists. Running Civi on WP.
    • British Humanist Association
  • CiviCRM version: 4.5.8
  • CMS version: WordPress 4.x
  • MySQL version: 5.5.x
  • PHP version: 5.5.x
Another pair of eyes on first pull request
May 06, 2015, 06:00:39 am
I'm trying to fix CRM-13596, and between me and NFP Services I think it's sorted:

https://github.com/awestbha/civicrm-core/commit/2868047209954c6d0284cc0de93bb6f520beee9a

But I haven't tried submitting any changes to core before, nor have I worked with git much. Could someone possibly take a quick look and check I haven't done anything ridiculous in terms of formatting / how things are meant to be done? Just before I update the issue and make a pull request.

Thanks very much,

Andrew

Coleman Watts

  • Administrator
  • I’m (like) Lobo ;)
  • *****
  • Posts: 2346
  • Karma: 183
  • CiviCRM version: The Bleeding Edge
  • CMS version: Various
Re: Another pair of eyes on first pull request
May 06, 2015, 06:51:16 pm
Code looks fine to me at first glance. I recommend you go ahead and create the PR which you can do from https://github.com/civicrm/civicrm-core/compare/master...awestbha:master
When you do it will run the automated code linting and unit tests which will give you more feedback.
Try asking your question on the new CiviCRM help site.

krypto

  • I post occasionally
  • **
  • Posts: 69
  • Karma: 5
  • IT guy for @bhahumanists. Running Civi on WP.
    • British Humanist Association
  • CiviCRM version: 4.5.8
  • CMS version: WordPress 4.x
  • MySQL version: 5.5.x
  • PHP version: 5.5.x
Re: Another pair of eyes on first pull request
May 07, 2015, 03:45:12 am
Thank you very much! Appreciate it. PR created.
Pages: [1]
  • CiviCRM Community Forums (archive) »
  • Old sections (read-only, deprecated) »
  • Developer Discussion (Moderator: Donald Lobo) »
  • Another pair of eyes on first pull request

This forum was archived on 2017-11-26.