CiviCRM Community Forums (archive)

*

News:

Have a question about CiviCRM?
Get it answered quickly at the new
CiviCRM Stack Exchange Q+A site

This forum was archived on 25 November 2017. Learn more.
How to get involved.
What to do if you think you've found a bug.



  • CiviCRM Community Forums (archive) »
  • Old sections (read-only, deprecated) »
  • Developer Discussion (Moderator: Donald Lobo) »
  • Remove Sunlight API integration?
Pages: [1]

Author Topic: Remove Sunlight API integration?  (Read 411 times)

John.K

  • I post occasionally
  • **
  • Posts: 75
  • Karma: 5
  • CiviCRM version: 4.x
  • CMS version: Drupal 7
  • MySQL version: 5.x
  • PHP version: 5
Remove Sunlight API integration?
March 08, 2016, 08:41:14 am
I've just stumbled across
CRM_Utils_Sunlight

This looks like an integration with the Sunlight Labs API. Which is fair enough, but why is this part of core if:
- It doesn't seem to be documented anywhere?
- The API key is 'baked in' to the code and would need to be overridden - there is no UI?
- It seems like it would only be required in very specific use cases
- I'm not even sure if the integration still works, I don't think the endpoint specified in the file still exists (http://api.sunlightlabs.com/) according to their site?

The class isn't called by anything else in Civi core that I can see, which makes it a perfect case for putting in an extension instead?

It's not my intention to annoy anyone by proposing this - if there is a legitimate reason to keep it in core then fair enough =]

JonGold

  • Ask me questions
  • ****
  • Posts: 638
  • Karma: 81
    • Palante Technology
  • CiviCRM version: 4.1 to the latest
  • CMS version: Drupal 6-7, Wordpress 4.0+
  • PHP version: PHP 5.3-5.5
Re: Remove Sunlight API integration?
March 08, 2016, 09:00:15 am
I've stumbled across this as well - and agree that it probably shouldn't be there.

FWIW, there IS an extension that supports it, but it's still buggy: The Electoral API extension. https://hq.palantetech.coop/projects/electoral-api/wiki/User_Documentation
Sign up to StackExchange and get free expert CiviCRM advice: https://civicrm.org/blogs/colemanw/get-exclusive-access-free-expert-help

John.K

  • I post occasionally
  • **
  • Posts: 75
  • Karma: 5
  • CiviCRM version: 4.x
  • CMS version: Drupal 7
  • MySQL version: 5.x
  • PHP version: 5
Re: Remove Sunlight API integration?
March 08, 2016, 09:04:16 am
There might be a couple of Drupal modules that use it too. But again, I think it should be it's own extension rather than in core =]
Thanks for the extra info.

Coleman Watts

  • Administrator
  • I’m (like) Lobo ;)
  • *****
  • Posts: 2346
  • Karma: 183
  • CiviCRM version: The Bleeding Edge
  • CMS version: Various
Re: Remove Sunlight API integration?
March 08, 2016, 10:20:48 am
Looks like that code is quite old... pre-git-migration; don't feel like digging into SVN history to find out exactly how old. I say delete it.
Try asking your question on the new CiviCRM help site.

Coleman Watts

  • Administrator
  • I’m (like) Lobo ;)
  • *****
  • Posts: 2346
  • Karma: 183
  • CiviCRM version: The Bleeding Edge
  • CMS version: Various
Re: Remove Sunlight API integration?
March 08, 2016, 04:36:07 pm
https://issues.civicrm.org/jira/browse/CRM-18192
Try asking your question on the new CiviCRM help site.

John.K

  • I post occasionally
  • **
  • Posts: 75
  • Karma: 5
  • CiviCRM version: 4.x
  • CMS version: Drupal 7
  • MySQL version: 5.x
  • PHP version: 5
Re: Remove Sunlight API integration?
March 09, 2016, 01:07:29 am
Cool =]

Pages: [1]
  • CiviCRM Community Forums (archive) »
  • Old sections (read-only, deprecated) »
  • Developer Discussion (Moderator: Donald Lobo) »
  • Remove Sunlight API integration?

This forum was archived on 2017-11-26.