CiviCRM Community Forums (archive)

I kept getting a CiviCRM fatal error when adding or deleting a user from an organic group with CiviCRM OG Sync enabled using CiviCRM 2.0.2.

The attached patch for CRM/Bridge/OG/Utils.php created with svn diff against head should fix that.

I also used the Drupal username to provide a first and possibly last name when creating CiviCRM accounts. This isn't necessarily a good practice, so feel free to remove it.

Great.

I'm now looking at the code that updates og membership when group membership is changed.

I have some attached some patches (CRM/Bridge/OG/Utils.php, drupal/civicrm_og_sync.module) that seem to handle things going the other way: user changes in CiviCRM causing updates to Drupal OG membership, but only for the normal and not yet the acl group in CiviCRM.

I think it may need to be expanded to handle acl stuff properly as follows:

• check the current user has the appropriate permissions on the Drupal side to either add/delete members, or add/delete admins
• if the civicrm is an acl group_type 1, then make sure there are other admins in Drupal group before allowing a delete. May need to look after making someone else a manager too.
• if the civicrm group is an ordinary group_type 2, then check if the uid to be deleted is an admin first, and if so , follow approach in 2, otherwise just unsubscribe the user from the group

Anything else come to mind?

I'm going to be busy for the next week at least, but thought I'd throw this out for comment and in case anyone else wanted to pick it up.