CiviCRM Community Forums (archive)

I ran into a significant issue in how the inherited memberships system works in 2.0 --

Basically, in addition to the membership record inheriting to the employees of the organization, the contribution record has also inherited. So if ABC Company becomes a member and pays $200, all employees of ABC Company have a membership record (good) but also a contribution record for the $200 payment (very bad). That's very problematic because it basically throws all contribution records/searches off.

Anyway, I tried to reproduce on 2.1 sandbox before submitting an issue, but the membership inheritance mechanism appears to be broken altogether. (which is why I'm posting here)

The following demo data is identical on both 2.0 and 2.1 sandboxes:
Membership org = Demo Membership Org
Company = ACME Company
Employee = John Doe
Employee = Jane Doe
Membership Type = Indiv inherits Org

Membership + Payment is assigned to ACME Company. In 2.0 sandbox, both membership and contribution inherit. In 2.1 sandbox, no inheritance takes place.

Jira: http://issues.civicrm.org/jira/browse/CRM-3371

I "think" Brian's issue is that multiple contribution records have been erroneously created (and we are looking at that based on the issue tracker item). Soft credit functionality requires a new way of linking a contribution record to "additional contacts" beyond the one that actually "made" the contribution. We don't yet have that in our data model (although I suspect we will in the future :-) ).

Yeah the very clear part is the killer. I have yet to see a system that handles it well...

Backport to 2.0 is easy -- things are just moved around in 2.1, which threw me off.

If you need this issue fixed in 2.0, in CRM/Member/Form/Membership.php, around line 507 (see two "ADDED" lines):

                    $params['status_id'] = CRM_Core_DAO::getFieldValue('CRM_Member_DAO_MembershipStatus', '0', 'id', 'is_current_member' );
                }
// we should not created contribution record for related contacts, CRM-3371 //ADDED
                unset( $params['contribution_status_id'] ); //ADDED

                $relatedMembership = CRM_Member_BAO_Membership::create( $params, CRM_Core_DAO::$_nullArray );
            }
        }