CiviCRM Community Forums (archive)

Hi,

I've been looking at the payment processors (in CiviCRM v2.1a4).

I notice that in CRM/Core/Payment/PayPalIPN.php lines 146-156 are responsible for adding new contribution objects for repeat contributions. By inspection it looks like there is error where the contribution_type_id is set:
$contribution->contribution_type_id  = $contributionType->id;

At this stage in the code there doesn't appear to be an active variable called $contributionType.

However although BaseIPN.php does define $contributionType and stores it in $objects["contributionType"] (BaseIPN.php line 116) in the function loadObjects() which has occured by this stage, so I suggest the following line is added prior to the above code (i.e. inserted at line 150)
$contributionType=$objects["contributionType"];

I reiterate that I've noticed this purely by inspection and I'm not actually using the PayPal payment processor so this is untested. Apologies if I'm incorrect.

Thanks,
   Dougall