CiviCRM Community Forums (archive)

- is it safe to just delete a contribution at this stage, or will there be other references to it?

IMO yes.

- what is the best way to code the deletion of this contribution?

You should use CRM_Contribute_BAO_Contribution::deleteContribution( $contributionId ); for deleting contribution.

HTH

Kurund

Sorry, I didn't word myself correctly, this was my assumption rather than yours (PayPalIPN.php is making no assumptions, it's simply doing it's job for PayPal IPNs!).

In PayPaylPN.php in the function recur() there is the following:
       if ( ! $first ) {
            // create a contribution and then get it processed
            $contribution =& new CRM_Contribute_DAO_Contribution( );
            $contribution->contact_id = $ids['contact'];
            $contribution->contribution_type_id  = $contributionType->id;
            $contribution->contribution_page_id  = $ids['contributionPage'];
            $contribution->contribution_recur_id = $ids['contributionRecur'];
            $contribution->receive_date          = $now;

            $objects['contribution'] =& $contribution;
        }

So my assumption is this: the first time a recurring payment IPN from PayPal is received, a contribution object is not created here in PayPalIPN since it has already been created by CiviCRM prior to transferring the donor's browser to the payment service. Is this correct?

The reason I was considering deleting this initial contribution is as follows:

For FuturePay (WorldPay's recurring payment mechanism) the initial IPN agreement provides a futurePayId and customized parameters with the relevant CiviCRM ids (contact, contribution, recurring contribution, contribution page and optionally membership).

In subsequent FuturePay IPN payments only the futurePayId is provided, so it is necessary to store these other ids in a db table at the start and retrieve them later when required.

Since the initial contribution is only relevant to the first recurring payment it seems a little inelegant (and possibly slightly confusing) to store it as well, so I thought I'd remove this initial contribution when the agreement is made and then create a new contribution each time a FuturePay payment notification is received.

This avoids the first FuturePay IPN payment being a special case where the contribution_id must be retrieved in addition to the other ids.

I hope this all sounds at least vaguely sensible!

Many thanks again,
  Dougall

I don't see this as an option in core - can anyone update me on what happened with WorldPay? cheers