CiviCRM Community Forums (archive)

*

News:

Have a question about CiviCRM?
Get it answered quickly at the new
CiviCRM Stack Exchange Q+A site
This forum was archived on 25 November 2017. Learn more.
How to get involved.
What to do if you think you've found a bug.



  • CiviCRM Community Forums (archive) »
  • Old sections (read-only, deprecated) »
  • Discussion (deprecated) »
  • Feature Requests and Suggestions (Moderator: Dave Greenberg) »
  • Bug CRM-2017 port to 1.7
Pages: [1]

Author Topic: Bug CRM-2017 port to 1.7  (Read 4384 times)

mrice

  • Guest
Bug CRM-2017 port to 1.7
June 21, 2007, 09:08:16 am
I reported Bug CRM-2017 for 1.7, and the fix was applied to 1.8, how do I request that this get ported to 1.7?

My production site is running 1.7, and I need this for my site to function correctly.

Dave Greenberg

  • Administrator
  • I’m (like) Lobo ;)
  • *****
  • Posts: 5760
  • Karma: 226
    • My CiviCRM Blog
Re: Bug CRM-2017 port to 1.7
June 21, 2007, 02:52:03 pm
Hi Matt - General software "best practice" is to apply bug fixes to the next release. The primary reasoning for this is that bug fixes can introduce other more serious bugs  -  and if fixes are backported, you need to allocate significant resources to make sure this doesn't happen. Whereas fixes in the forthcoming release will be validated through a full release QA cycle.

The good news is that this fix is quite local and relatively easy to apply - so assuming you have a test copy of your site, you can make the change and try it out - it's one line as described in this link:

http://fisheye.civicrm.org/viewrep/CiviCRM/branches/v1.8/CRM/Member/BAO/Membership.php?r1=10061&r2=10064

Hope that helps.
Protect your investment in CiviCRM by  becoming a Member!

mrice

  • Guest
Re: Bug CRM-2017 port to 1.7
June 21, 2007, 04:17:10 pm
The fix that scared me was this one:

http://fisheye.civicrm.org/changelog/CiviCRM/?cs=10068

It is also listed on the changes related to that bug, or am I missing something:
http://issues.civicrm.org/jira/browse/CRM-2017?page=com.cenqua.fisheye.jira:fisheye-tabpanel

Donald Lobo

  • Administrator
  • I’m (like) Lobo ;)
  • *****
  • Posts: 15963
  • Karma: 470
    • CiviCRM site
  • CiviCRM version: 4.2+
  • CMS version: Drupal 7, Joomla 2.5+
  • MySQL version: 5.5.x
  • PHP version: 5.4.x
Re: Bug CRM-2017 port to 1.7
June 21, 2007, 04:58:49 pm

thats the merge 1.8 into trunk fix and as such can/should be ignored. We need to figure out how to tell jira/fisheye to ignore comments with merge in them

lobo
A new CiviCRM Q&A resource needs YOUR help to get started. Visit our StackExchange proposed site, sign up and vote on 5 questions

Piotr Szotkowski

  • I live on this forum
  • *****
  • Posts: 1497
  • Karma: 57
Re: Bug CRM-2017 port to 1.7
June 22, 2007, 12:33:11 am
The whole point of putting the CRM-XXXX issue numbers in the merge comments is to be able to track whether the fix got to trunk or not, and if so, in which revision. If we don’t want that, I can drop this practice, but I consider it a Good Thing™.

As for my eyes, the FishEye tab of CRM-2017 states more or less clearly that this issue was fixed in r10064 on branches/v1.8 and migrated to trunk (alongside CRM-1936, CRM-2023 and other things) in r10068, and that the original file to patch is CRM/Member/BAO/Membership.php…
If you found the above helpful, please consider helping us in return – you can even steer CiviCRM’s future and help us extend CiviCRM in ways useful to you.

mrice

  • Guest
Re: Bug CRM-2017 port to 1.7
June 24, 2007, 07:45:04 am
The change to membership.php did the trick.

Now I just have to figure out how to remove the contribute section if the contribution is $0

Donald Lobo

  • Administrator
  • I’m (like) Lobo ;)
  • *****
  • Posts: 15963
  • Karma: 470
    • CiviCRM site
  • CiviCRM version: 4.2+
  • CMS version: Drupal 7, Joomla 2.5+
  • MySQL version: 5.5.x
  • PHP version: 5.4.x
Re: Bug CRM-2017 port to 1.7
June 24, 2007, 08:23:16 am

This is implemented in v1.8 where we allow $0 contributions (i.e. no call is made to payment processor etc)

lobo
A new CiviCRM Q&A resource needs YOUR help to get started. Visit our StackExchange proposed site, sign up and vote on 5 questions

mrice

  • Guest
Re: Bug CRM-2017 port to 1.7
June 24, 2007, 03:16:40 pm
Is there a reference to the change log so I can try to implement the fix on 1.7?

Donald Lobo

  • Administrator
  • I’m (like) Lobo ;)
  • *****
  • Posts: 15963
  • Karma: 470
    • CiviCRM site
  • CiviCRM version: 4.2+
  • CMS version: Drupal 7, Joomla 2.5+
  • MySQL version: 5.5.x
  • PHP version: 5.4.x
Re: Bug CRM-2017 port to 1.7
June 24, 2007, 03:31:48 pm

Unfortunately not. Since this was an issue and we changed quite a few files to get this to work. The backport is non-trivial, if u can figure out the changes :) v1.8 alpha is due out soon (in a week or so?), maybe u can help test it :)

lobo
A new CiviCRM Q&A resource needs YOUR help to get started. Visit our StackExchange proposed site, sign up and vote on 5 questions
Pages: [1]
  • CiviCRM Community Forums (archive) »
  • Old sections (read-only, deprecated) »
  • Discussion (deprecated) »
  • Feature Requests and Suggestions (Moderator: Dave Greenberg) »
  • Bug CRM-2017 port to 1.7

This forum was archived on 2017-11-26.