CiviCRM Community Forums (archive)

I am migrating our production site to v2.1.  Because of another issue, I happened to create a membership for a member in the new installation.  The rules referenced in the post below (which was about importing memberships) are in force.  The new membership used these dates:
Join: May 27, 2007
Start: Jan. 1, 2008

CiviMember should have selected Communicant but it selected Good Standing which is marked "Admin Only".  This is similar behavior to that fixed in the issue CRM-3570 except that issue was on import rather than creating the membership from the contact's membership tab.

Is anyone else having similar issues?  Should I file one?

Status	Start Event	Start Event Adj.	End Event	End Event Adj.	Current Membership?	Admin Only?	Weight	Default?	Enabled
New	join date		join date	1 year	X		1		X
Good Standing	start date		start date	1 year	X	X	2		X
Communicant	start date		start date	1 year	X		3	X	X
Deceased	start date		end date			X	4		X
Inactive	start date					X	5		X
Pending	join date		join date				6		X
Cancelled	end date		end date			X	7		X

Hi,

I know this is a very old issue but I believe I've tracked down a bug in 4.2.8 with a similar cause. I'll post details but I thought I'd ask this question first...

For CRM-3570, a new param was added to CRM_Member_BAO_MembershipStatus::getMembershipStatusByDate(): $excludeIsAdmin = FALSE .

This left bug CRM-3724, mentioned in this topic.

What I'm wondering is: are there ANY circumstances where getMembershipStatusByDate() should include statuses with is_admin = 1 ? The help text for the "Administrator Only?" field on membership status edit form (/civicrm/admin/member/membershipStatus?action=update&id=N&reset=1) says:

"Check this box if this status is for use by administrative staff only. If checked, this status is never automatically assigned by CiviMember. It is assigned to a contact's Membership by checking the Status Override flag when adding or editing the Membership record. Start and End Event settings are ignored for Administrator statuses. EXAMPLE: This setting can be useful for special case statuses like 'Non-expiring', 'Barred' or 'Expelled', etc."

This suggests to me that a status with is_admin = 1 should never be returned by getMembershipStatusByDate().

Is that right?

If so, seems to me the $excludeIsAdmin isn't needed and getMembershipStatusByDate() should always exclude is_admin = 1, which I think will solve the other bug I've encountered.

Dave J