Author Topic: Zen starterkit theme and adding to group (Read 3538 times)

jalama · January 20, 2009, 03:11:15 pm

I'm having an issue with the rendering of the add to group verification page created when one is confirming adding a contact to a group from a groups manage group page (as opposed to adding from the advanced search). A sample url is /civicrm/group/search?_qf_AddToGroup_display=true&qfKey=6f7bbe4ed946806c2ba4f0d1e88e0f3e

For some reason the left-sidebar container is not rendering at all, so far only on this page, meaning any bocks in the left sidebar are not contained and render on top of the body content (you cannot click buttons or links). This only happens in Zen Starterkit and the custom theme I developed from Starterkit, everything is okay in Garland and Zen. I realize this is more likely an issue with those themes but I wanted to make sure there wasn't something special about this page (i.e. uses special javascript or xml to render, etc...). I have cereated this issue on 3 servers all running Drupal 6.9 and civi 2.1.4 and zen 6.1 beta3 (additionally php 5.2+).

Thanks

jalama · January 25, 2009, 08:08:35 pm

I seem to have found the issue here

It lies in the template files. For the issue i addressed above the issue is in the /civicrm/templates/CRM/Contact/Form/Task/AddToGroup.tpl file. Starting at line 32 changing moving line 33 to line 37 eliminates the error. It should read as below. the error seems to be in inserting the <script> tag before the beginning of the if statement. If the <script> tag is not moved the first half of the left-sidebar disappears form sight as the browser reads it as javascript.

Code: [Select]

{literal} 

{/literal}
{if !$group.id}
{literal}
<script type="text/javascript">
{/literal}
{if !$group.id}
{literal}
<script type="text/javascript">
showElements();

on a related front I was having a similar error when a user went to delete an activity from the dashboard. The error is fixed by changing the /civicrm/CRM/templates/Activity/From/Activity.tpl file starting at line 198 to only show the <script> tag if necessary. I tested adding a new activity and this fix works there.

Code: [Select]

{* Build add contact *}
{if $action eq 1 or $action eq 2 or $context eq 'search'}
{literal}
<script type="text/javascript">
{/literal}
{/if}

Dave Greenberg · February 04, 2009, 04:27:19 pm

Thx for reporting these. I've posted an issue and fix for the "Add to Group" task (slightly different from your code example) for 2.2:
http://issues.civicrm.org/jira/browse/CRM-4087

I think the Activity form problem should be fixed already in 2.2 - that tpl was restructured quite a bit and I don't see a condition where the <script> tag would be unclosed. Would be great if you could try both with your themes when the next beta comes out, to confirm.

jalama · February 26, 2009, 12:53:58 pm

Lobo,

I tested this today with 2.2 beta3, everything works fine

Thanks

CiviCRM Community Forums (archive)

News:

Author Topic: Zen starterkit theme and adding to group (Read 3538 times)

jalama

Zen starterkit theme and adding to group

jalama

Re: Zen starterkit theme and adding to group

Dave Greenberg

Re: Zen starterkit theme and adding to group

jalama

Re: Zen starterkit theme and adding to group