CiviCRM Community Forums (archive)

Hi:

We're trying to track down a problem with data importation in 2.1.4.  Basically, some empty fields cause problems.

Looking at the code, it would appear that the code in getActiveFieldParams (at approximately line 629 of ...../Import/Parser.php) is assigning array-type values to each element of the array $params, making it an array of arrays.  Yet most of the code we've looked at in ...../Import/Parser/Contact.php wants to treat these as scalar values.  The result is that when there is no value with which to stuff an element of $params  (say, $params[foo]), various bits of code that look like

if ($params[foo] && whatever){
   ... do something...
}

always execute because (as an array) $params[foo] will always be defined, even if empty.  Results are, of course, unpredictable depending on data values etc.  We do notice that some error messages that should be returning the value of a $params element as part of the message are returning the string 'Array' instead, and that preg_replace complains of receiving array rather than string values in various places where it's used.

I have to admit I'm wondering if we have this right, if only because this is a pretty wide-ranging problem and I'd expect more complaints over this kind of breakage.  But I suppose it's possible that nobody else has hit this yet.

Thoughts?

I did not reproduce it on the sandbox (I work with tbruce) -- but see last paragraph.

 We are getting a lot of "Invalid value for field(s) : Birth-Date; Is Deceased; Deceased Date; Individual Suffix; Individual Prefix; Gender ..." errors which make no sense to me because I do not believe our data is actually malformed.

At the same time drupal is throwing a errors at the top of the page in its red box:
"# warning: preg_match() expects parameter 2 to be string, array given in
/var/www/html/patron/modules/civicrm/CRM/Utils/Date.php on line 590.
# warning: preg_match() expects parameter 2 to be string, array given in /var/www/html/patron/modules/civicrm/CRM/Utils/String.php on line 288.
# warning: preg_match() expects parameter 2 to be string, array given in /var/www/html/patron/modules/civicrm/CRM/Utils/String.php on line 290."

The one error I did get in the sandbox which I didn't understand was a invalid value message for the gender field, when the imported  field was nothing but the string "F" or the string "M".  I stopped trying to import to the Gender field, and that was when I succeeded. Am I missing something?

- Brian Hughes