CiviCRM Community Forums (archive)

*

News:

Have a question about CiviCRM?
Get it answered quickly at the new
CiviCRM Stack Exchange Q+A site

This forum was archived on 25 November 2017. Learn more.
How to get involved.
What to do if you think you've found a bug.



  • CiviCRM Community Forums (archive) »
  • Old sections (read-only, deprecated) »
  • Support »
  • Using CiviCRM »
  • Using Drupal Modules (Moderator: Donald Lobo) »
  • Using Administration Menu module with CiviCRM, cuts off the "reset=1" parameter
Pages: [1]

Author Topic: Using Administration Menu module with CiviCRM, cuts off the "reset=1" parameter  (Read 5121 times)

CiviTeacher.com

  • I live on this forum
  • *****
  • Posts: 1282
  • Karma: 118
    • CiviTeacher
  • CiviCRM version: 3.4 - 4.5
  • CMS version: Drupal 6&7, Wordpress
  • MySQL version: 5.1 - 5.5
  • PHP version: 5.2 - 5.4
Using Administration Menu module with CiviCRM, cuts off the "reset=1" parameter
April 09, 2009, 11:08:57 am
Anyone out there use this Administration Menu module and notice that it cuts off the parameters from the CiviCRM links in the drop down menu.  Of course this causes all kinds of nonsense and confusion on certain CiviCRM pages when you can't reset the search results by clicking Find Contacts again.

Solution anyone?  Contacted Administration Menu people and they haven't responded yet.

Try CiviTeacher: the online video tutorial CiviCRM learning library.

Dave Greenberg

  • Administrator
  • I’m (like) Lobo ;)
  • *****
  • Posts: 5760
  • Karma: 226
    • My CiviCRM Blog
Re: Using Administration Menu module with CiviCRM, cuts off the "reset=1" parameter
April 11, 2009, 09:01:38 pm
Kurund and I looked at this and we don't know of a fix. If we pass in the query string (reset=1 or other parameters) - the module doesn't work (all the CiviCRM items disappear). Let us know if anyone comes up with a fix / patch (either something we can change in our implementation of the admin menu hook or ??).

BTW for 2.3 we are looking at implementing a top-bar drop-down menu for CiviCRM - which will probably "replace" the admin menu when you're viewing a CiviCRM page or form (so this may become a moot point).
Protect your investment in CiviCRM by  becoming a Member!

CiviTeacher.com

  • I live on this forum
  • *****
  • Posts: 1282
  • Karma: 118
    • CiviTeacher
  • CiviCRM version: 3.4 - 4.5
  • CMS version: Drupal 6&7, Wordpress
  • MySQL version: 5.1 - 5.5
  • PHP version: 5.2 - 5.4
Re: Using Administration Menu module with CiviCRM, cuts off the "reset=1" parameter
May 19, 2009, 12:44:11 pm
Hi I thought I would revisit this issue.

Some folks in the CiviCRM community speak highly of Administration Menu (admin_menu) module, but the fact that it removes the &reset=1 from the links means that Contact and Group searching becomes completely unusable if accessed through the Administration Menu by a regular non-programming user who doesn't understand manual URL manipluation (aka copying and pasting &reset=1 every darn time).

I wonder if people who like Administration Module with CiviCRM even use the admin_menu to do Contact searching and are aware of this problem?  It boggles my mind.   In my opinion CiviCRM should not have an admin_menu if the links to Find Contacts , etc  .... don't work because they can never be reset unless manually editing the URL line is done. (which is silly and something a non-technical user doesn't get)

Is integration of CiviCRM with the admin_module optional?  Can we turn it off through CiviCRM?

Because the CiviCRM links in admin_module don't work, I would like to have admin_module active for everything BUT CiviCRM.

I contacted the curator of admin_module and he appears completely unaware of CiviCRM's existence or this problem and even suggests that CiviCRM links don't belong in the Admin Module in the first place:

Quote
I don't use CiviCRM, so I am unable to debug this.

Also, I don't quite understand this issue. admin_menu contains administrative links only. The path of the links you mentioned do not start with admin/*, so they should not be contained in the menu.
http://drupal.org/node/425866

So...any ideas?  Can I remove CiviCRM links up in the Admin Menu?




« Last Edit: May 19, 2009, 01:43:26 pm by Stoob »
Try CiviTeacher: the online video tutorial CiviCRM learning library.

Chris Burgess

  • Ask me questions
  • ****
  • Posts: 675
  • Karma: 59
Re: Using Administration Menu module with CiviCRM, cuts off the "reset=1" parame
May 19, 2009, 02:30:10 pm
Here's a link to the issue: http://drupal.org/node/425866

CiviCRM currently isn't passing in ?reset=1, so we need to fix that for admin_menu to handle the case correctly. However, if we add that query string, admin_menu URLencodes it, so we end up with links to eg http://example.com/?q=civicrm/dashboard%3Freset%3D1

I can't see (at a glance) if Admin Menu handles the addition of query params at all.

If not, it should, but because we are apparently the only people with this requirement, we'll need to provide the patch, rather than telling sun it's a problem with his code - which he believes has never needed to support query params except for this case.

I hadn't noticed this issue before (but tbh, I don't spend a lot of time doing contact searches like a regular user might).

Quote
Also, I don't quite understand this issue. admin_menu contains administrative links only. The path of the links you mentioned do not start with admin/*, so they should not be contained in the menu.

At a glance of my admin_menu, I see links which start with: devel/*, admin_menu/*, user/*, logout ... so I'm not sure the distinction is quite as clear as that. Still, we're the ones with a need here; we'll need to be the ones providing sun a patch.
« Last Edit: May 19, 2009, 02:36:48 pm by xurizaemon »
@xurizaemon ● www.fuzion.co.nz

Chris Burgess

  • Ask me questions
  • ****
  • Posts: 675
  • Karma: 59
Re: Using Administration Menu module with CiviCRM, cuts off the "reset=1" parame
May 19, 2009, 02:31:55 pm
Quote from: Dave Greenberg on April 11, 2009, 09:01:38 pm
BTW for 2.3 we are looking at implementing a top-bar drop-down menu for CiviCRM - which will probably "replace" the admin menu when you're viewing a CiviCRM page or form (so this may become a moot point).

If at all possible, I think our users would prefer a combined menu to two separate top-bar dropmenus. The distinction between CMS and CRM functionality is totally opaque to most mortals, and IMO should not be made explicit in the GUI.

(Of course, I understand why CiviCRM would want a menu of its own, rather than depending on the admin_menu module for Drupal only. But to lose that functionality for people already using the otherwise excellent admin_menu would be a real shame.)
@xurizaemon ● www.fuzion.co.nz

CiviTeacher.com

  • I live on this forum
  • *****
  • Posts: 1282
  • Karma: 118
    • CiviTeacher
  • CiviCRM version: 3.4 - 4.5
  • CMS version: Drupal 6&7, Wordpress
  • MySQL version: 5.1 - 5.5
  • PHP version: 5.2 - 5.4
Re: Using Administration Menu module with CiviCRM, cuts off the "reset=1" parameter
May 20, 2009, 09:35:10 am
Ok thanks for the information.  I had no idea that CiviCRM wasn't passing the parameter to Admin_menu in the first place, and why no one realized that the parameter was necessary for proper searching.  Unfortunately I don't feel qualified to offer a patch to Sun's code, but I do know that he is only actively developing admin_menu 6.x-3.x version.

I do find it fascinating that no one else has noticed this before I raised it as a user, although it has been an issue for at least 2 months, maybe more.  As primarily a user of CiviCRM and as a light-weight programmer secondly, I think that sometimes I notice bugs that only a user would notice, which is interesting.  Sometimes I wonder how many people are actually really seriously using CiviCRM on a day-to day basis to run their businesses, and why they haven't raised this issue about admin_menu before.

I am going post a bug-tracker issue about this and hopefully we can get a patch for admin_menu: http://issues.civicrm.org/jira/browse/CRM-4513
« Last Edit: May 20, 2009, 09:43:29 am by Stoob »
Try CiviTeacher: the online video tutorial CiviCRM learning library.

Chris Burgess

  • Ask me questions
  • ****
  • Posts: 675
  • Karma: 59
Re: Using Administration Menu module with CiviCRM, cuts off the "reset=1" parame
May 21, 2009, 06:45:31 pm
I'm in the converse role - programmer first, CiviCRM user rarely - and I concur that many bugs don't get reported. I think it's not so much that few people are seriously using CiviCRM, and rather that the users of a complex tool are quick to learn and then sidestep its intricate behaviours, rather than engage with the programming trolls who will grunt their terrible grunts and interrogate them for details like "steps to reproduce".

I say that as one of the coders who has to occasionally twist a user's arm for those most valuable details. If we technicians aren't careful to assist them in making good bug reports, we run the risk of scaring the best source of bugs away from trying to report them in future...
@xurizaemon ● www.fuzion.co.nz

Chris Burgess

  • Ask me questions
  • ****
  • Posts: 675
  • Karma: 59
Re: Using Administration Menu module with CiviCRM, cuts off the "reset=1" parame
May 21, 2009, 06:57:41 pm
http://issues.civicrm.org/jira/browse/CRM-4513 patch attached
@xurizaemon ● www.fuzion.co.nz

CiviTeacher.com

  • I live on this forum
  • *****
  • Posts: 1282
  • Karma: 118
    • CiviTeacher
  • CiviCRM version: 3.4 - 4.5
  • CMS version: Drupal 6&7, Wordpress
  • MySQL version: 5.1 - 5.5
  • PHP version: 5.2 - 5.4
Re: Using Administration Menu module with CiviCRM, cuts off the "reset=1" parameter
May 22, 2009, 10:03:32 am
Interesting thoughts, yes sometimes there is a disconnect between programmer and user - I guess this is the case for all software.   Thanks for making the patch.  If I can offer something to community perhaps it's to help bridge that gap.
Try CiviTeacher: the online video tutorial CiviCRM learning library.

Pages: [1]
  • CiviCRM Community Forums (archive) »
  • Old sections (read-only, deprecated) »
  • Support »
  • Using CiviCRM »
  • Using Drupal Modules (Moderator: Donald Lobo) »
  • Using Administration Menu module with CiviCRM, cuts off the "reset=1" parameter

This forum was archived on 2017-11-26.