CiviCRM Community Forums (archive)

There were a few bugs in the original code re: tokens (this was a community contribution) that I had run into while implementing for a v2.2 installation. Here's the revised function in CRM/Mailing/BAO/Mailing.php. Haven't tested on v3.0 yet, but it looks like they just plugged it in from the original version, so this fix should work.

    public function commonLetterCompose ( &$form )
    {
        //get the tokens.
        $tokens = CRM_Core_SelectValues::contactTokens( );
        if ( CRM_Utils_System::getClassName( $form )  == 'CRM_Mailing_Form_Upload' ) {
            $tokens = array_merge( CRM_Core_SelectValues::mailingTokens( ), $tokens );
        }

        $form->add( 'select', 'token2',  ts( 'Insert Tokens' ),
                    $tokens , false,
                    array(
                          'size'     => "5",
                          'multiple' => true,
                          'onchange' => "return tokenReplText(this);"
                          )
                    );
       
        $form->add( 'select', 'token1',  ts( 'Insert Tokens' ),
                    $tokens , false,
                    array(
                          'size'     => "5",
                          'multiple' => true,
                          'onchange' => "return tokenReplHtml(this);"
                          )
                    );
       
        require_once 'CRM/Core/BAO/MessageTemplates.php';
        $form->_templates = CRM_Core_BAO_MessageTemplates::getMessageTemplates();
        if ( !empty( $form->_templates ) ) {
            $form->assign('templates', true);
            $form->add('select', 'template', ts('Select Template'),
                       array( '' => ts( '- select -' ) ) + $form->_templates, false,
                       array('onChange' => "selectValue( this.value );") );
            $form->add('checkbox','updateTemplate',ts('Update Template'), null);
        }
       
        $form->add('checkbox','saveTemplate',ts('Save As New Template'), null,false,
                          array( 'onclick' => "showSaveDetails(this);" ));
        $form->add('text','saveTemplateName',ts('Template Title'));
     
       
        //insert message Text by selecting "Select Template option"
        $form->add( 'textarea',
                    'text_message',
                    ts('Text Message'),
                    array('cols' => '80', 'rows' => '8',
                          'onkeyup' => "return verify(this)"));
        $form->addWysiwyg( 'html_message',
                           ts('HTML Message'),
                           array('cols' => '80', 'rows' => '8',
                                 'onkeyup' =>"return verify(this)" ) );
}

Just did some testing.

The problem I had fixed in Al's original code is not the problem (I don't think). The problem is with the actual token insertion -- instead of inserting the token value, it inserts the token label. So if you select "Display Name" from the popup it inserts "Display Name" in the body of the textarea, where it should insert "{contact.display_name}"

I tested with manually inserting the token in the body and it does work. I also tested the email function and that works correctly -- inserting the token value. So something's goofed up with the token insert on the pdf letter form.

I just tested on the demo and it's not working. Here's how to reproduce:

1. Run a search.
2. Select all contacts
3. Select "create pdf letter from contacts"
4. Insert token

The token is inserted with the label, not the token text. See screenshot.

Thanks Brian and Kurund for helping on this.

Unfortunately, it's still not working on sandbox. I tried creating a letter for just one contact, Donald Adams, with basic tokens (first, last, address, city, state, zip) and the tokens now insert properly but are not converted upon PDF generation.

Attached is the PDF that was created.

Thanks
Tony

Oh ok. I see.  It's working now. I just used a bad example.

Thanks Kiran!

Tony

make sure your selected contact should not be deceased.

can u try to replicate on : http://sandbox.civicrm.org/

If issue persists, give your list of sample contacts for which tokens are not replaced.

thanks
kiran