Author Topic: Upgrade to 3.2.2 breaks javascript (Read 4130 times)

bcobin · August 19, 2010, 10:39:39 am

I'm modifying the initial post title here, because what was a problem in 3.2.1 that could be worked around with CiviTheme is unavoidable in 3.2.2, at least in my case. Whereas this was an inconvenience before, this is now a show-stopper - CiviTheme doesn't work at all in 3.2.2.

---- Original post ----

I'm performing a new installation over here and the help balloons don't activate. Additionally, you get the "Javascript must be enabled in your browser" message in the dashboard, although configuring the dashboard does work. I would assume the two are related.

Uh oh - Advanced Settings for Profiles doesn't work either.

This is Mac on both Firefox and Safari.

UPDATE - This looks like a theme issue; workaround (for Drupal) is to use CiviCRM Theme and work in a base Drupal theme for Civi.

ANOTHER UPDATE: There is a problem. See below.

Kurund Jalmi · August 23, 2010, 03:46:08 am

What's the name of the theme that conflicts with CiviCRM?

Kurund

bcobin · August 23, 2010, 04:56:05 am

Thanks for checking on this, Kurund - this is a highly-modified version of ATCK; in this case, it's basically a reconstruction of a Drupal 5 site in D6. ATCK is (purposefully) very stripped-down; I prefer to do my own custom theming and it's possible that mine might be a pretty specific case where these javascript problems are concerned.

I'll look into this further with some other sites I've done and get back to you - thanks for looking into this!

bcobin · August 24, 2010, 11:00:42 am

I stand corrected here - on another site I'm working on, I just updated to 3.2.2 and there's something wacko here - displays are "broken" and, strangely, hitting the "printer-friendly" button opens up another page where the page displays as it should, more or less, but "outside" the page (no body tags).

On this site, just having the the Drupal CiviCRM Theme module installed breaks Civi javascript entirely - I get the "you must have javascript enabled" message.

Yikes!

Kurund Jalmi · August 24, 2010, 11:11:03 am

Quote

On this site, just having the the Drupal CiviCRM Theme module installed breaks Civi javascript entirely - I get the "you must have javascript enabled" message.

CiviCRM Theme module allows you to change the theme, I don't think it will break javascript. Also make sure you have latest version of CiviCRM Theme drupal.

Kurund

bcobin · August 24, 2010, 01:21:44 pm

I've tried everything I can think off without success. It looks like my only solution here would be to try to restore to 3.2.1 - with about 20,000 contacts between two clients, this is something I really don't want to have to try.

Any ideas here? See the following from an earlier post which might provide a clue:

Quote

displays are "broken" and, strangely, hitting the "printer-friendly" button opens up another page where the page displays as it should, more or less, but "outside" the page (no body tags).

I am at a loss.... any suggestions greatly appreciated - thanks!

Donald Lobo · August 24, 2010, 01:41:16 pm

if you have drupal performance (admin/user/performance) turned on, disable it and see if that works. if so, delete files/js and files/css and you can turn it back on

if the above does not work, consider hiring someone from http://civicrm.org/professional/ to take a look at it

lobo

bcobin · August 24, 2010, 02:17:59 pm

Thank you, Donald - on both sites, turning off CSS compression works and turning CSS compression on breaks the Civi display. So the solution is simple: have everybody use Safari or Firefox and get rid of IE!

But seriously, there's a problem here - it's an either/or choice between the site displaying properly for IE users or for Civi admins. That won't work.

I have a 3.1.5 site that I haven't upgraded yet and notice that the code in the body tags are very different - I'll transcribe and post here. Therein might lie a solution? Ick.

(Code is manually transcribed from a screen capture, so there might be errors... careful!)

3.1.5:

Code: [Select]

<html class="js" lang="en" xmlns="http://www.w3.org/1999/xhtml" xml:lang="en">
<head>
<body class="not-front logged-in page-civicrm two-sidebars i18n-en lightbox-processed" onpageshow="null;event.persisted && CKEDITOR.tools.callFunction(0)" style="border-bottom: 0px none;">

3.2.2

Code: [Select]

<html class="js" lang="en" xmlns="http://www.w3.org/1999/xhtml" xml:lang="en" dir="ltr">
<head>
<body onpageshow="event.persisted && (function(){var allInstances = CKEDITOR.instances, editor, doc;for ( var i in allInstances ){ editor = allInstances[ i ]; doc = editor.document; if (doc ) { doc.$.designMode = "off"; doc.$.designMode = "on"; }}})();">

Donald Lobo · August 24, 2010, 02:21:35 pm

Quote from: bcobin on August 24, 2010, 02:17:59 pm

But seriously, there's a problem here - it's an either/or choice between the site displaying properly for IE users or for Civi admins. That won't work

if this wont work for your users, please consider hiring a developer to investigate and figure out whats happening, why and a solution

open source works when people step up and contribute and help in figure out solutions to "this wont work" problems

lobo

bcobin · August 24, 2010, 02:39:37 pm

Code: [Select]

open source works when people step up and contribute and help in figure out solutions to "this wont work" problems
Of course! I was being somewhat flippant - please excuse the tone; I am always most appreciative of help!

See modified post with code additions above. Not everybody is working with sites that will exceed the 31-stylesheet limit for IE, and thus, they wouldn't see the problem unless the CSS was compressed. For those who are (like me), this looks to be a major issue.

Could it work to replace the 3.2.2 code with the 3.1.5 code here? Or would that be a mess? (The code was manually transcribed, so be forewarned!) Thanks, as always...

pbarmak · August 24, 2010, 02:48:06 pm

Not sure this will help, but I just had this issue as well when I upgraded from 3.2.1 to 3.2.2. lobo helped me out on IRC and the initial solution was to turn off CSS Optimization in Drupal (same work-around you did).

Now, since then I decided to see if the issue was related to the 3.2.2 updated CSS files under ../all/modules/civicrm/css. I went back to my 3.2.1 backup and copied all the files in the css folder to my production folder, overwriting the current files. Then I went and turned CSS Optimization back on in Drupal and ... guess what? It worked.

Something seems incorrect about at least 1 of the css files in 3.2.2 such that, when putting them into a single, compressed file, it's messing up the interface. I haven't figure out exactly which one, but I'll reply back when I do. I'm wondering if maybe a file is not properly encoded?

In any case, to me this seems like a bug, though maybe that can be argued - but it is functionality that worked in the previous release and is now broken and it seems to be due to something new in the css files.

Hope this helps a little.

pbarmak · August 24, 2010, 02:53:17 pm

OK, I should have held my reply for a second ... it's definitely the civicrm.css file. I replaced just that one from 3.2.1 and things look fine to me. Here is a partial diff output - notice there seems to be an odd character (E with the accent) in the first diff. Remove that character and things seem to work, for me at least.

Code: [Select]

2348c2348
< #crm-create-new-link {
---
> #crm-create-new-link É{

Donald Lobo · August 24, 2010, 02:57:10 pm

can u file an issue, we'll fix in 3.2.3

lobo

pbarmak · August 24, 2010, 03:00:59 pm

Created here: http://issues.civicrm.org/jira/browse/CRM-6723

bcobin, if you can verify removing that bad character works, that would be great.

bcobin · August 24, 2010, 03:03:30 pm

You are both total rockstars! Looks like that did the trick... excellent!

Thank you SO much, guys - just one little "E'"

CiviCRM Community Forums (archive)

News:

Author Topic: Upgrade to 3.2.2 breaks javascript (Read 4130 times)

bcobin

Upgrade to 3.2.2 breaks javascript

Kurund Jalmi

Re: Javascript problems in 3.2.1 [Theme Issue]

bcobin

Re: Javascript problems in 3.2.1 [Theme Issue]

bcobin

Re: Javascript problems in 3.2.2

Kurund Jalmi

Re: Javascript problems in 3.2.1 [Theme Issue]

bcobin

Re: Upgrade to 3.2.2 breaks javascript

Donald Lobo

Re: Upgrade to 3.2.2 breaks javascript

bcobin

Re: Upgrade to 3.2.2 breaks javascript

Donald Lobo

Re: Upgrade to 3.2.2 breaks javascript

bcobin

Re: Upgrade to 3.2.2 breaks javascript

pbarmak

Re: Upgrade to 3.2.2 breaks javascript

pbarmak

Re: Upgrade to 3.2.2 breaks javascript

Donald Lobo

Re: Upgrade to 3.2.2 breaks javascript

pbarmak

Re: Upgrade to 3.2.2 breaks javascript

bcobin

Re: Upgrade to 3.2.2 breaks javascript