CiviCRM Community Forums (archive)

*

News:

Have a question about CiviCRM?
Get it answered quickly at the new
CiviCRM Stack Exchange Q+A site

This forum was archived on 25 November 2017. Learn more.
How to get involved.
What to do if you think you've found a bug.



  • CiviCRM Community Forums (archive) »
  • Old sections (read-only, deprecated) »
  • Support »
  • Using CiviCRM »
  • Using CiviContribute (Moderator: Donald Lobo) »
  • Possible bug - 4.2.6: Contribution page for membership signup only - no amount
Pages: [1] 2

Author Topic: Possible bug - 4.2.6: Contribution page for membership signup only - no amount  (Read 3890 times)

DamonKirkpatrick

  • I post occasionally
  • **
  • Posts: 58
  • Karma: 0
  • One job but so many responsibilities.
    • Friends of Georgia State Parks
  • CiviCRM version: 4.5.2
  • CMS version: Drupal 7.35
  • MySQL version: 5.1.48
  • PHP version: 5.3.8
Possible bug - 4.2.6: Contribution page for membership signup only - no amount
November 08, 2012, 10:05:13 am
Not sure if this is a bug or just a feature change that I don't yet understand.  I have recreated on the demo site. 

On a membership signup page, each membership level has a particular fee (and contribution type) associated with it.  On my site, we don't use price sets, just the regular functionality.  Users were unable, after the upgrade, to select a membership level and have that amount added to the total.  I moved to the demo site to test basic functionality and here's what I found.

On the demo site, I created a contribution page for membership signup.  No donation section or anything extra.  The membership level appears with the dollar figure associated with it.  If I select that level and then complete the form and submit, I receive error "contribution amount is a required field" (see attached screenshot).  It appears the system is not picking up the Membership fee as an amount.

On my system, the error also occurred but in much more complex ways.  Sounds like a bug to me but, as I said, it might be a feature that I don't understand.  When I tested this prior to upgrade, I purchased a membership with an additional donation and it seemed to work fine.  Memberships WITHOUT additional donations are not generating an amount field (which, of course, I didn't test).

Any help would be appreciated.

Thanks!

***UPDATE***

With some additional testing on my site and demo, I have a bit more information.  No solution yet though.

On my site, if the membership section is the only section available on the contribution page (meaning no option for additional contributions) everything seems to work fine.  However, if I add the "Additional Contributions" section, a few weird things start to happen.

The amount (total) is not displayed at all.
If I select a membership that costs $50 and then choose an additional contribution in the amount of $10, I receive an error that the membership requires a contribution of at least $50, almost as if it were acting like a premium.
If I choose no additional contribution then I get an error stating the Amount must be specified.
If I increase the additional contribution to above the cost of the membership, it processes ONLY the price of the additional contribution without any regard to the cost of the membership.  It's almost like it is ignoring the membership price in the total altogether but IS checking to make sure the "Additional contribution" is higher than the price of the membership.
« Last Edit: November 08, 2012, 12:38:28 pm by Stoic »

petednz

  • Forum Godess / God
  • I’m (like) Lobo ;)
  • *****
  • Posts: 4899
  • Karma: 193
    • Fuzion
  • CiviCRM version: 3.x - 4.x
  • CMS version: Drupal 6 and 7
Re: Possible bug - 4.2.6: Contribution page for membership signup only - no amount
November 08, 2012, 02:12:21 pm
I flagged some issues that I think are related here - http://forum.civicrm.org/index.php/topic,26651.msg113135.html#msg113135

in as much as we were getting members being billed twice on the form post-upgrade before we did some reconstruction on the form. Just in case it helps pinpoint the problem at least in regard to the upgrade
Sign up to StackExchange and get free expert advice: https://civicrm.org/blogs/colemanw/get-exclusive-access-free-expert-help

pete davis : www.fuzion.co.nz : connect + campaign + communicate

Dave Greenberg

  • Administrator
  • I’m (like) Lobo ;)
  • *****
  • Posts: 5760
  • Karma: 226
    • My CiviCRM Blog
Re: Possible bug - 4.2.6: Contribution page for membership signup only - no amount
November 08, 2012, 02:18:54 pm
I think this is working "as expected" and I don't think this has changed in recent releases. The contribution input field works differently depending on whether the 'Separate Membership Payment' checkbox is checked in the contribution page configuration Memberships tab.

If that box is NOT checked, the input field label is "Contribution Amount" - and the user is expected to enter a value equal to or greater than the selected membership fee IF they select a membership. (Folks using this method generally add some info explaining this in the page intro section.)

If Separate Membership Payment is checked, then the label changes to 'Additional Contribution' and the amount is handled that way (added to the selected membership fee).

... and if the Contribution Amounts section enabled checkbox on the Amounts tab is NOT checked, then there's not contribution amount input and only the membership fee is charged.

I did notice that you have input fields for discounts - so I'm thinking you have the discounts extension enabled ?? There may be some issues with that code and the 4.2 codebase so it would be helpful to narrow down what you're seeing with and without the extension enabled.
Protect your investment in CiviCRM by  becoming a Member!

Dave Greenberg

  • Administrator
  • I’m (like) Lobo ;)
  • *****
  • Posts: 5760
  • Karma: 226
    • My CiviCRM Blog
Re: Possible bug - 4.2.6: Contribution page for membership signup only - no amount
November 08, 2012, 02:24:21 pm
Meant to include this help screenshot which might explain expected behavior more clearly.
Protect your investment in CiviCRM by  becoming a Member!

DamonKirkpatrick

  • I post occasionally
  • **
  • Posts: 58
  • Karma: 0
  • One job but so many responsibilities.
    • Friends of Georgia State Parks
  • CiviCRM version: 4.5.2
  • CMS version: Drupal 7.35
  • MySQL version: 5.1.48
  • PHP version: 5.3.8
Re: Possible bug - 4.2.6: Contribution page for membership signup only - no amount
November 08, 2012, 03:44:47 pm
Thanks for the response.

I have been back through all my testing notes and tried to recreate the scenarios again and seem to be getting different results.  It may be that I got confused during my initial testing.  As you suggested, Dave, it does appear to be working as designed.

So, I went back to square one and removed the Discount extension, enable separate transaction, and the contribution amount. 

On my system it is now back to working as expected with a few minor exceptions.  The additional donation section used to contain a header where we asked people to add an additional donation and the premiums area was nearby.  Also, the premium seems to be looking at the total contribution for the membership page, not just the additional contribution.  In our case, we sell memberships and then encourage folks to add a donation along with their membership to receive their gift.  Previously, the premium looked only at the additional contribution field for the total (at least I assume so) and now it is looking at the total for the page including the  membership amount.  I will continue testing but would appreciate your insight.  In hindsight, users trying to make additional contributions is what brought all this to my attention in the first place.

As to the upgrade, I'm not really sure why my contribution pages started working differently than they had in the past.  I'm going to test more so I can make sure it is working as it did  and will report my results. 

Any thoughts about the premium issue?

DamonKirkpatrick

  • I post occasionally
  • **
  • Posts: 58
  • Karma: 0
  • One job but so many responsibilities.
    • Friends of Georgia State Parks
  • CiviCRM version: 4.5.2
  • CMS version: Drupal 7.35
  • MySQL version: 5.1.48
  • PHP version: 5.3.8
Re: Possible bug - 4.2.6: Contribution page for membership signup only - no amount
November 08, 2012, 07:08:26 pm
Starting to get this fixed and sorted. 

However, I noticed the "Additional Contribution" label is missing from the additional contribution area.  On previous versions, it was segmented away from the membership options and clearly labeled.  Now the membership options and the additional contribution options are together and the "Additional Contribution" section has no label.  Might be nice if it had a settings configuration with intro text like premiums do.  In either case, bringing the label back would help.  I think I found the code that generates the label but I have NO IDEA where to force it to actually display.

Screen shot from demo (joomla) is attached.

Thanks.

**UPDATE**

I have verified the "Additional Contribution" label is missing.  Starting a new forum post as it seems to be a bit off topic from my original.
« Last Edit: November 09, 2012, 08:05:12 am by Stoic »

Dave Greenberg

  • Administrator
  • I’m (like) Lobo ;)
  • *****
  • Posts: 5760
  • Karma: 226
    • My CiviCRM Blog
Re: Possible bug - 4.2.6: Contribution page for membership signup only - no amount
November 09, 2012, 03:57:05 pm
Everything is really a price set in 4.2 - and you're hitting an edge case. As in my screenshot, the "Additional Contribution" field label is supplied if you just have Other Amount, but it's suppressed for radio button sets in 'additional' contribution amounts.

The "work-around" is for you to convert your page to use a price set explicitly by clicking the link in the Memberships tab: "Click here if you want to configure the Membership Types below as part of a Price Set, with the added flexibility and complexity that entails."

Then you will be able to control / edit price field labels for each of the sections AND use the price field 'help' to add instructions etc. See screenshot of your test page converted to explicit price set.
Protect your investment in CiviCRM by  becoming a Member!

Dave Greenberg

  • Administrator
  • I’m (like) Lobo ;)
  • *****
  • Posts: 5760
  • Karma: 226
    • My CiviCRM Blog
Re: Possible bug - 4.2.6: Contribution page for membership signup only - no amount
November 09, 2012, 03:58:15 pm
BTW - if you're setting up examples / tests on the demo sites it's really helpful if you include a link the example so others (me in this case) don't have to search for it :-)
Protect your investment in CiviCRM by  becoming a Member!

DamonKirkpatrick

  • I post occasionally
  • **
  • Posts: 58
  • Karma: 0
  • One job but so many responsibilities.
    • Friends of Georgia State Parks
  • CiviCRM version: 4.5.2
  • CMS version: Drupal 7.35
  • MySQL version: 5.1.48
  • PHP version: 5.3.8
Re: Possible bug - 4.2.6: Contribution page for membership signup only - no amount
November 09, 2012, 05:13:07 pm
Thanks, Dave.  It looks like I'm going to need to spend some time with the price sets. 

Right now, one of the functionality issues that concerns me is that (unless I'm wrong) donations made from within a membership price set are coded as the Member Dues contribution type.  From an accounting perspective, the old method allowed me to separate donation funds from membership funds even if they came from the same page.  This was very handy as, for us, donations and memberships are definitely NOT the same thing.  I'm sure I can add custom fields for this but it really limits the functionality of the fund types. 

At this point, I'm going to plead ignorance and go do some more reading and research.  We've used the system this way for about three years now and it might take me a minute to get my head around how to make sure we're recording funds properly.

Thanks for all your help and the advice about linking to the demo site.  I'll definitely do that in the future!

Dave Greenberg

  • Administrator
  • I’m (like) Lobo ;)
  • *****
  • Posts: 5760
  • Karma: 226
    • My CiviCRM Blog
Re: Possible bug - 4.2.6: Contribution page for membership signup only - no amount
November 09, 2012, 05:42:05 pm
Hmm - I don't think you want to give up on the fund separation you currently have, and in 4.2 you would have to if you use explicit price sets. I did some more digging and figured out that the 'Additional Contribution' label is not showing due to a bug in one of the templates. I'll come up with a fix for that in the next day or so and post back here. In the meantime - the missing label is your only issue and you're "in production" - you can patch it with this temporary fix. You will get an 'extra' label on the Membership Levels radio as well - but that might be fine.

in templates/CRM/Price/Form/PriceSet.tpl - line 38, change from this:
                <div class="label">{if $quickConfig}{$event.fee_label} <span class="crm-marker" title="This field is required.">*</span>{else}{$form.$element_name.label}{/if}</div>

to this:
                <div class="label">{if $quickConfig && $extends NEQ 'Membership'}{$event.fee_label} <span class="crm-marker" title="This field is required.">*</span>{else}{$form.$element_name.label}{/if}</div>
Protect your investment in CiviCRM by  becoming a Member!

Dave Greenberg

  • Administrator
  • I’m (like) Lobo ;)
  • *****
  • Posts: 5760
  • Karma: 226
    • My CiviCRM Blog
Re: Possible bug - 4.2.6: Contribution page for membership signup only - no amount
November 12, 2012, 11:17:16 am
Committed that changed for the next 4.2 release (http://issues.civicrm.org/jira/browse/CRM-11167).
Protect your investment in CiviCRM by  becoming a Member!

DamonKirkpatrick

  • I post occasionally
  • **
  • Posts: 58
  • Karma: 0
  • One job but so many responsibilities.
    • Friends of Georgia State Parks
  • CiviCRM version: 4.5.2
  • CMS version: Drupal 7.35
  • MySQL version: 5.1.48
  • PHP version: 5.3.8
Re: Possible bug - 4.2.6: Contribution page for membership signup only - no amount
December 06, 2012, 02:01:36 pm
Thanks, Dave -

Sorry it took me so long to test.  It seems to have worked, but now I'm running into additional problems that all seem related.

1.  I can only recreate this one sometimes and I was able to do it on the demo site.
With ContAmounts Enabled and Separate Payments enabled, I added some default amounts to a membership page.  The first time a user hits that page, if they select "No Thank You" for the Additional Contribution amount (after entering all the other required fields as well) when they press "Confirm Contribution" they get an error "Amount is required".  If they then select No Thank You again, it seems to go through fine and process normally.

2.  When adding in the "Additional Contribution" amounts, it seems to have pulled additional amounts form a cache somewhere so I get multiple repeated amounts.  I've attached a screenshot from the demo site and here's the link to the page I created in the demo:  http://joomla.demo.civicrm.org/index.php?option=com_civicrm&task=civicrm/contribute/transact&reset=1&id=4

If you turn off the Other amounts setting and then go in and turn it on again and recreate it, you get even more options.  I tried the purge cache option on my site and it didn't make any difference.  I've tried multiple computers and multiple browsers and all get the same result.  I dug through the database to see if I could find where those entries are stored and just manually delete them and I was not able to find them. 

Thanks.
« Last Edit: December 06, 2012, 02:06:05 pm by Stoic »

Dave Greenberg

  • Administrator
  • I’m (like) Lobo ;)
  • *****
  • Posts: 5760
  • Karma: 226
    • My CiviCRM Blog
Re: Possible bug - 4.2.6: Contribution page for membership signup only - no amount
December 11, 2012, 10:51:29 am
Hmm - I can see that things look pretty messed up on the Joomla demo for this test page. The amounts on the contribution form don't correspond with the amounts in the Configure Online Contribution Page > Amounts tab at http://joomla.demo.civicrm.org/administrator/?option=com_civicrm&task=civicrm/admin/contribute/amount&reset=1&action=update&id=4

That said, I tried to replicate this on my local 4.2 and could not cause things to get out of synch. Would be good if you could start with a new online contribution page and note down the exact steps (including URLs) you used to "break things", and post back here.
Protect your investment in CiviCRM by  becoming a Member!

DamonKirkpatrick

  • I post occasionally
  • **
  • Posts: 58
  • Karma: 0
  • One job but so many responsibilities.
    • Friends of Georgia State Parks
  • CiviCRM version: 4.5.2
  • CMS version: Drupal 7.35
  • MySQL version: 5.1.48
  • PHP version: 5.3.8
Re: Possible bug - 4.2.6: Contribution page for membership signup only - no amount
December 12, 2012, 06:00:43 am
I hope this is what you were looking for.  I created this test on the joomla demo site.  I included links to the contribution page and the exact steps I took to recreate the problems.

Please let me know if you need any additional information.  I'm not technical enough to fix code but I'll help in any way I can.  For my organization this is preventing us from accepting donations with memberships through the holiday season so I am very eager to help fix it any way I can.  Thanks for your help.

For testing on the joomla demo site, I tried to create a contribution page almost exactly like the one we use in production (which is having these same problems).

1.  Created new contribution page with membership options.  Provided pay later option for ease of testing.
2.  Enabled contribution amounts section and Allow other amounts. min $5 max $5000
3.  Set fixed contribution options with no default set. (5,10,15,20)
4.  Enabled Membership Section  Used membership types General and Student.  Required Membership Signup.  Chose Separate Membership Payment.
5.  New contribution page was created with ID 5.

Testing the page
1.  Connected to the "Live Page" through the links option on the contribution page.  Connected to:  http://joomla.demo.civicrm.org/index.php?option=com_civicrm&task=civicrm/contribute/transact&reset=1&id=5

Result - Everything loaded correctly and appeared as expected.

2.  Selected "General" for membership level and "No thank you" for Contribution Amount.  Entered Email address.  Clicked "Confirm Contribution"

Result - Confirmation pages and Thank you pages displayed as expected with the correct amount.

Creating the error
1.  Edited the contribution page.  On the Contribution Amounts section, deselected "Contribution Amounts Section enabled"
2.  "Save and Done" results in informational error "To disable Contribution Amounts section you need to first disable Separate Membership Payment option from Membership Settings.".  Went to Membership settings section and disabled separate Membership Payment option.  Saved, then returned to Contribution Amounts and disabled the Contribution Amounts Section.
3.  Refreshed live page and everything looked as expected.
4.  Turn Contribution Amounts Section back on.  Set amounts to (7,12,17,22).
5.  Re-enabled "Separate Membership Payment"
6.  Save and Done.

Visit "Live Page" for results (http://joomla.demo.civicrm.org/index.php?option=com_civicrm&task=civicrm/contribute/transact&reset=1&id=5)

Unexpected result:  Under contribution Amount Section, all the values that had ever been input as Additional Contribution options are now displayed (5,7,10,12,15,17,20,22).  If you repeat the process of disabling the contribution amounts section, saving, then re-enabling it, you'll end up with yet another full set of numbers added to the Additional Contributions list. 

Browsers tested - IE, Safari, Chrome and Firefox.

Additional unexpected result NOT REPLICATED in this test:  On our live page, after encountering this problem, the system would create only one transaction in CiviCRM contribution records but was recording multiple transactions of the same amount through our payment processor.  I will try to replicate this with more details. 







Donald Lobo

  • Administrator
  • I’m (like) Lobo ;)
  • *****
  • Posts: 15963
  • Karma: 470
    • CiviCRM site
  • CiviCRM version: 4.2+
  • CMS version: Drupal 7, Joomla 2.5+
  • MySQL version: 5.5.x
  • PHP version: 5.4.x
Re: Possible bug - 4.2.6: Contribution page for membership signup only - no amount
December 12, 2012, 08:06:08 am

for the real short term, you can go into the DB and delete the rows associated with the older contributions. I suspect it is in civicrm_option_group / civicrm_option_value tables

lobo
A new CiviCRM Q&A resource needs YOUR help to get started. Visit our StackExchange proposed site, sign up and vote on 5 questions

Pages: [1] 2
  • CiviCRM Community Forums (archive) »
  • Old sections (read-only, deprecated) »
  • Support »
  • Using CiviCRM »
  • Using CiviContribute (Moderator: Donald Lobo) »
  • Possible bug - 4.2.6: Contribution page for membership signup only - no amount

This forum was archived on 2017-11-26.